Enforce test duration across reboots and restarts #4416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
added
bug
LecrisUT
approved these changes
Dec 11, 2025
vaibhavdaren
approved these changes
Dec 24, 2025
Tests that triggered reboots and restarts were given their full duration on every invocation. This behavior is most likely incorrect, a duration should apply to the whole test, no matter how many times it reboots a guest. Patch adds `Duration` object which poses a strict deadline, derived from the test `duration` key. Unlike a timeout, it is not reset after guest reboot or test restart.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that triggered reboots and restarts were given their full duration on every invocation. This behavior is most likely incorrect, a duration should apply to the whole test, no matter how many times it reboots a guest.
Patch adds
Durationobject which poses a strict deadline, derived from the testdurationkey. Unlike a timeout, it is not reset after guest reboot or test restart.Pull Request Checklist