Move /plans/provision/container into its own Packit job
#4400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
force-pushed
the
provision-mock-container-into-distinct-jobs
branch
from
e7efd52 to
abc7325
Compare
happz
force-pushed
the
provision-mock-container-into-distinct-jobs
branch
from
abc7325 to
fafc6f2
Compare
psss
added
the
area | maintenance
LecrisUT
reviewed
Dec 4, 2025
Contributor
LecrisUT
left a comment
LecrisUT
left a comment
There was a problem hiding this comment.
Just minor moving around
Comment on lines
+134
to
+135
| # TODO: can I merge `provision` and `internal`? They seem to fight over `tf_extra_params`, | ||
| # dropping keys. |
Contributor
There was a problem hiding this comment.
I did try this one at some point, and iirc it does an update, of the previously defined fields, so the conflict should be fine.
Contributor
Author
There was a problem hiding this comment.
I tried, virtual check found no tests as it was missing the custom context. Will try again.
Contributor
There was a problem hiding this comment.
packit validate should show the final yaml file, but we should see this from a simple yaml.load also.
| - tmt: | ||
| context: | ||
| how: provision | ||
| <<: *tmt-cloud-resources |
Contributor
There was a problem hiding this comment.
Suggested change
I believe you want to remove this, otherwise it is the same as internal except for missing use_internal_tf?
Comment on lines
+148
to
+151
| settings: | ||
| provisioning: | ||
| tags: | ||
| BusinessUnit: tmt |
Contributor
There was a problem hiding this comment.
Suggested change
| settings: | |
| provisioning: | |
| tags: | |
| BusinessUnit: tmt | |
| <<: *tmt-cloud-resources |
We already have a shortcut :)
LecrisUT
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist