Refactor for mock plugin #4173
Merged
Refactor for mock plugin #4173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoncek
force-pushed
the
mock-provision
branch
2 times, most recently
from
f9fb10e to
7258200
Compare
mkoncek
added
step | provision
mkoncek
changed the title
mkoncek
force-pushed
the
mock-provision
branch
from
58006d8 to
53a0fa9
Compare
8 tasks
LecrisUT
reviewed
Oct 31, 2025
mkoncek
force-pushed
the
mock-provision
branch
from
53a0fa9 to
8802ffc
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
LecrisUT
reviewed
Nov 3, 2025
LecrisUT
added
the
ci | full test
LecrisUT
force-pushed
the
mock-provision
branch
from
c2e40b9 to
31af6b7
Compare
LecrisUT
approved these changes
Nov 14, 2025
Contributor
LecrisUT
left a comment
LecrisUT
left a comment
There was a problem hiding this comment.
Sorry for not noticing these before (fresh eyes and all that), but there are just a few more refactoring suggestions, but otherwise lgtm.
LecrisUT
approved these changes
Nov 18, 2025
Contributor
LecrisUT
left a comment
LecrisUT
left a comment
There was a problem hiding this comment.
Awesome, thanks for the work on this 🙂
mkoncek
force-pushed
the
mock-provision
branch
from
6b83a88 to
cfadbf0
Compare
mcasquer
approved these changes
Dec 16, 2025
8 tasks
Contributor
|
/packit rebuild-failed |
Contributor
|
Unrelated failures, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This among others fixes
Fix the /tests/provision/mock/fedora-rawhide-x86_64/provision-prepare tracebackmentioned in: #4097Pull Request Checklist