Pass the original node content to adjust decision callback #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
requested review from
janhavlin,
lukaszachy,
martinhoyer,
psss and
thrix
as code owners
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Because I would really like to show the diff between "before" and "after", and callback was getting just one version.
happz
force-pushed
the
adjust-decision-sees-original
branch
from
94d7aab to
e258835
Compare
LecrisUT
reviewed
Jun 25, 2025
| self._merge_special(self.data, apply_rule) | ||
|
|
||
| if decision_callback: | ||
| node_before = self.copy() |
Contributor
There was a problem hiding this comment.
Should it deep_copy instead in case the merge changes something like a list, or is that already taken care of?
Contributor
Author
There was a problem hiding this comment.
I thought there's deepcopy used, but when I play with it I see no change between before and after, and I suspect the copy is not as deep as I expected...
Contributor
Author
There was a problem hiding this comment.
Nevermind, deepcopy is there, and what I saw was PEBKAC.
Contributor
Author
|
An example of tmt output when this becomes available - it borrows from the similar output of
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I would really like to show the diff between "before" and "after", and callback was getting just one version.
Checklist