Allow dashes in context dimension names #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszachy
approved these changes
Jan 15, 2025
Contributor
|
@psss any objections to squeeze this into 1.6.1 ? |
Contributor
Author
|
Agreed to include it. And as it's not just a bug fix, let' call the release |
It's quite common to name multi-word keys with dashes instead of underscores. Let's allow dashes in the context dimension names as well.
lukaszachy
force-pushed
the
dash-in-context-dimension-name
branch
from
b9ffe0c to
a211226
Compare
lukaszachy
requested review from
happz,
janhavlin,
martinhoyer and
thrix
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's quite common to name multi-word keys with dashes instead of underscores. Let's allow dashes in the context dimension names as well.