Add dynamic version and hash fetching for ExifTool #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalsleuth
changed the title
Contributor
|
I'd rather leave this hardcoded and use renovate bot to inform about new versions vs pulling this dynamic all the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the recent PR submission here by winl0gon, we have just been having a discussion regarding exiftool over at the REMnux repo and making it a dynamically updating state.
To this end, I'd like to propose that we use the changes in this PR to account for updating the version and hash values in exiftool by means of the
requestsbackend and fetching them from the exiftool site. This will address PR 194 as well.