Skip to content

Conversation

@AsciiWolf
Copy link
Contributor

@AsciiWolf AsciiWolf commented Feb 4, 2025

Closes #348.

@tchx84
Copy link
Owner

tchx84 commented Feb 6, 2025

@AsciiWolf would you be interested in trying to port this project's CI to flatter? like I use with Gameeky and Flatseal ?

EDIT: This way, we won't need to to test anything else elsewhere.

@AsciiWolf AsciiWolf changed the title manifest: Bump to GNOME 47 runtime Bump to GNOME 47 runtime, migrate CI to flatter Feb 7, 2025
@AsciiWolf
Copy link
Contributor Author

@tchx84 Done. :-)

@tchx84
Copy link
Owner

tchx84 commented Feb 7, 2025

@tchx84 Done. :-)

good start! it's just missing pytest, black and pyflakes dependencies so the actual tests can run, see Gameeky as an example:

@AsciiWolf
Copy link
Contributor Author

  [0/1] Running all tests.
  1/5 Validate desktop file OK              0.01s
  2/5 Validate schema file  OK              0.01s
  3/5 pyflakes              OK              0.55s
  4/5 black                 OK              1.20s
  5/5 pytest                OK              1.43s
  
  Ok:                 5   
  Expected Fail:      0   
  Fail:               0   
  Unexpected Pass:    0   
  Skipped:            0   
  Timeout:            0   

@tchx84
Copy link
Owner

tchx84 commented Feb 11, 2025

  [0/1] Running all tests.
  1/5 Validate desktop file OK              0.01s
  2/5 Validate schema file  OK              0.01s
  3/5 pyflakes              OK              0.55s
  4/5 black                 OK              1.20s
  5/5 pytest                OK              1.43s
  
  Ok:                 5   
  Expected Fail:      0   
  Fail:               0   
  Unexpected Pass:    0   
  Skipped:            0   
  Timeout:            0   

Awesome, only the appstream validation is missing now :)

EDIT: see https://github.com/tchx84/Gameeky/blob/main/data/meson.build#L62

@AsciiWolf
Copy link
Contributor Author

  [0/1] Running all tests.
  1/6 Validate desktop file   OK              0.01s
  2/6 Validate schema file    OK              0.01s
  3/6 Validate appstream file OK              0.02s
  4/6 pyflakes                OK              0.51s
  5/6 black                   OK              1.15s
  6/6 pytest                  OK              1.37s
  Ok:                 6   
  Expected Fail:      0   
  Fail:               0   
  Unexpected Pass:    0   
  Skipped:            0   
  Timeout:            0   

Done. :-)

@AsciiWolf AsciiWolf requested a review from tchx84 February 11, 2025 22:38
@AsciiWolf
Copy link
Contributor Author

@tchx84 I think this is now ready to be merged. :-)

@tchx84 tchx84 merged commit 721339f into tchx84:master Feb 19, 2025
1 check passed
@tchx84
Copy link
Owner

tchx84 commented Feb 19, 2025

@AsciiWolf thanks, let me know if you have time (or will for other contributions) :) Because I have a TODO hah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update runtime to 47

2 participants