Refactor Dockerfiles to use multi-stage builds #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the Dockerfiles in `genkit` and `socket.io` to implement multi-stage builds. The first stage, named 'builder', is responsible for installing dependencies (including devDependencies like npm) and building the application. The second stage creates a lean production image by copying only the necessary artifacts (the `dist` folder and production `node_modules`) from the 'builder' stage. This approach significantly reduces the final image size and improves security by excluding npm and other development tools from the production environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the Dockerfiles in
genkitandsocket.ioto implement multi-stage builds.The first stage, named 'builder', is responsible for installing dependencies (including devDependencies like npm) and building the application.
The second stage creates a lean production image by copying only the necessary artifacts (the
distfolder and productionnode_modules) from the 'builder' stage.This approach significantly reduces the final image size and improves security by excluding npm and other development tools from the production environment.