synolia · Jibbarth · Sep 8, 2025 · Aug 22, 2025 · Aug 22, 2025 · Aug 27, 2025
diff --git a/assets/admin/entrypoint.js b/assets/admin/entrypoint.js
@@ -1,2 +1 @@
 // Mandatory by test application
-// whereas it's useless
diff --git a/assets/settings/constants.scss b/assets/settings/constants.scss
diff --git a/assets/shop/entrypoint.js b/assets/shop/entrypoint.js
@@ -1,2 +1 @@
 // Mandatory by test application
-// whereas it's useless
diff --git a/config/config.yml b/config/config.yml
@@ -1,5 +1,4 @@
 imports:
     - { resource: "state_machine.yml" }
     - { resource: "resources.yaml" }
-#    - { resource: "ui.yaml" }
     - { resource: "twig_hooks/*.yaml" }
diff --git a/config/services/gateway.xml b/config/services/gateway.xml
@@ -1,10 +1,20 @@
 <?xml version="1.0" ?>
-
+<!--
+    This service file was used to register payum gateways.
+    We don't use payum anymore, but if mandatory, you can import this file to register them and still use payum
+-->
 <container xmlns="http://symfony.com/schema/dic/services"
            xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
            xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
     <services>
         <defaults autoconfigure="true" autowire="true" public="false"/>
+        <!-- Gateway PayPlug -->
+        <service id="payplug_sylius_payplug_plugin.gateway_factory.payplug"
+                 class="Payum\Core\Bridge\Symfony\Builder\GatewayFactoryBuilder">
+            <argument type="string">PayPlug\SyliusPayPlugPlugin\Gateway\PayPlugGatewayFactory</argument>
+            <tag name="payum.gateway_factory_builder"
+                 factory="payplug" />
+        </service>
 
         <!-- Gateway Oney By PayPlug -->
         <service id="payplug_sylius_payplug_plugin.gateway_factory.oney"
@@ -37,35 +47,5 @@
             <tag name="payum.gateway_factory_builder"
                  factory="payplug_american_express"/>
         </service>
-
-        <service id="payplug_sylius_payplug_plugin.is_oney_enabled_validator"
-                 class="PayPlug\SyliusPayPlugPlugin\Gateway\Validator\Constraints\IsOneyEnabledValidator">
-            <argument type="service" id="PayPlug\SyliusPayPlugPlugin\ApiClient\PayPlugApiClientFactory" />
-            <tag name="validator.constraint_validator" alias="PayPlug\SyliusPayPlugPlugin\Gateway\Validator\Constraints\IsOneyEnabledValidator" />
-        </service>
-
-        <service id="payplug_sylius_payplug_plugin.is_payplug_secret_key_validator"
-                 class="PayPlug\SyliusPayPlugPlugin\Gateway\Validator\Constraints\IsPayPlugSecretKeyValidator">
-            <argument type="service" id="PayPlug\SyliusPayPlugPlugin\ApiClient\PayPlugApiClientFactory" />
-            <tag name="validator.constraint_validator" alias="PayPlug\SyliusPayPlugPlugin\Gateway\Validator\Constraints\IsPayPlugSecretKeyValidator" />
-        </service>
-
-        <service id="payplug_sylius_payplug_plugin.is_can_save_cards_validator"
-                 class="PayPlug\SyliusPayPlugPlugin\Gateway\Validator\Constraints\IsCanSaveCardsValidator">
-            <argument type="service" id="PayPlug\SyliusPayPlugPlugin\ApiClient\PayPlugApiClientFactory" />
-            <tag name="validator.constraint_validator" alias="PayPlug\SyliusPayPlugPlugin\Gateway\Validator\Constraints\IsCanSaveCardsValidator" />
-        </service>
-
-        <service id="payplug_sylius_payplug_plugin.is_can_save_payment_method_validator"
-                 class="PayPlug\SyliusPayPlugPlugin\Gateway\Validator\Constraints\IsCanSavePaymentMethodValidator">
-            <argument type="service" id="PayPlug\SyliusPayPlugPlugin\ApiClient\PayPlugApiClientFactory" />
-            <tag name="validator.constraint_validator" alias="PayPlug\SyliusPayPlugPlugin\Gateway\Validator\Constraints\IsCanSavePaymentMethodValidator" />
-        </service>
-
-        <service id="payplug_sylius_payplug_plugin.permission_validator"
-                 class="PayPlug\SyliusPayPlugPlugin\Gateway\Validator\Constraints\PayplugPermissionValidator">
-            <argument type="service" id="PayPlug\SyliusPayPlugPlugin\ApiClient\PayPlugApiClientFactory" />
-            <tag name="validator.constraint_validator" alias="PayPlug\SyliusPayPlugPlugin\Gateway\Validator\Constraints\PayplugPermissionValidator" />
-        </service>
     </services>
 </container>
diff --git a/config/twig_hooks/shop.yaml b/config/twig_hooks/shop.yaml
@@ -25,15 +25,6 @@ sylius_twig_hooks:
                 template: '@PayPlugSyliusPayPlugPlugin/shared/modal/index.html.twig'
                 priority: 0
 
-        # TODO: check if this is possible only on select_payment page
-        'sylius_shop.checkout#stylesheets':
-            select_payment_css:
-                template: '@PayPlugSyliusPayPlugPlugin/stylesheets/select_payment_css.html.twig'
-
-        'sylius_shop.order#stylesheets':
-            select_payment_css:
-                template: '@PayPlugSyliusPayPlugPlugin/stylesheets/select_payment_css.html.twig'
-
         'sylius_shop.shared.form.select_payment.payment':
             choice:
                 template: '@PayPlugSyliusPayPlugPlugin/shared/form/select_payment/payment/choice.html.twig'

diff --git a/config/ui.yaml b/config/ui.yaml
diff --git a/src/Command/Handler/CapturePaymentRequestHandler.php b/src/Command/Handler/CapturePaymentRequestHandler.php
@@ -4,6 +4,7 @@
 
 namespace PayPlug\SyliusPayPlugPlugin\Command\Handler;
 
+use Payplug\Exception\HttpException;
 use PayPlug\SyliusPayPlugPlugin\ApiClient\PayPlugApiClientFactoryInterface;
 use PayPlug\SyliusPayPlugPlugin\ApiClient\PayPlugApiClientInterface;
 use PayPlug\SyliusPayPlugPlugin\Command\CapturePaymentRequest;
@@ -40,6 +41,23 @@ public function __invoke(CapturePaymentRequest $capturePaymentRequest): void
             throw new \LogicException('Payment method is not set for the payment.');
         }
 
+        if (PayPlugApiClientInterface::STATUS_CREATED === ($payment->getDetails()['status'] ?? null)) {
+            $paymentRequest->setResponseData([
+                'retry' => true,
+                'message' => 'Payment already created',
+                'payment_id' => $payment->getDetails()['payment_id'] ?? 'unknown',
+                'redirect_url' => $payment->getDetails()['redirect_url'] ?? null, // @phpstan-ignore-line
+            ]);
+
+            $this->stateMachine->apply(
+                $paymentRequest,
+                PaymentRequestTransitions::GRAPH,
+                PaymentRequestTransitions::TRANSITION_COMPLETE,
+            );
+
+            return;
+        }
+
         $client = $this->apiClientFactory->createForPaymentMethod($method);
         $data = $this->paymentDataCreator->create($payment)->getArrayCopy();
 
@@ -53,13 +71,26 @@ public function __invoke(CapturePaymentRequest $capturePaymentRequest): void
         $data['notification_url'] = $notificationUrl;
 
         $paymentRequest->setPayload($data);
-        $payplugPayment = $client->createPayment($data);
+
+        try {
+            $payplugPayment = $client->createPayment($data);
+        } catch (HttpException $exception) {
+            $paymentRequest->setResponseData(\json_decode($exception->getHttpResponse(), true)); // @phpstan-ignore-line
+            $this->stateMachine->apply(
+                $paymentRequest,
+                PaymentRequestTransitions::GRAPH,
+                PaymentRequestTransitions::TRANSITION_FAIL,
+            );
+
+            return;
+        }
         $arrayPayplugPayment = (array) $payplugPayment;
         $payment->setDetails([
             ...$payment->getDetails(),
             'status' => PayPlugApiClientInterface::STATUS_CREATED,
             'payment_id' => $payplugPayment->__get('id'),
             'payplug_response' => $arrayPayplugPayment,
+            'redirect_url' => $payplugPayment->hosted_payment->payment_url, // @phpstan-ignore-line
         ]);
 
         $paymentRequest->setResponseData(array_merge($arrayPayplugPayment, [

diff --git a/src/DependencyInjection/PayPlugSyliusPayPlugExtension.php b/src/DependencyInjection/PayPlugSyliusPayPlugExtension.php
@@ -25,9 +25,7 @@ public function load(array $configs, ContainerBuilder $container): void
         $xmlloader = new XmlFileLoader($container, new FileLocator(dirname(__DIR__, 2) . '/config/services'));
 
         $ymlloader->load('services.yaml');
-        // TODO: migrate to YAML
         $xmlloader->load('client.xml');
-        $xmlloader->load('gateway.xml');
     }
 
     public function prepend(ContainerBuilder $container): void
@@ -42,12 +40,10 @@ private function prependTwigExtension(ContainerBuilder $container): void
             return;
         }
 
-        // TODO: check if still mandatory on v2
         $container->prependExtensionConfig('twig', [
             'form_themes' => [
                 '@PayPlugSyliusPayPlugPlugin/form/form_gateway_config_row.html.twig',
                 '@PayPlugSyliusPayPlugPlugin/form/sylius_checkout_select_payment_row.html.twig',
-                '@PayPlugSyliusPayPlugPlugin/form/complete_info_popin.html.twig',
             ],
         ]);
     }

diff --git a/src/Entity/CardsOwnerInterface.php b/src/Entity/CardsOwnerInterface.php
@@ -13,5 +13,5 @@ interface CardsOwnerInterface
      */
     public function getCards(): Collection;
 
-    public function addCard(Card $card): static;
+    public function addCard(Card $card): self;
 }
diff --git a/src/Gateway/Validator/Constraints/IsCanSaveCards.php b/src/Gateway/Validator/Constraints/IsCanSaveCards.php
diff --git a/src/Gateway/Validator/Constraints/IsCanSaveCardsValidator.php b/src/Gateway/Validator/Constraints/IsCanSaveCardsValidator.php
diff --git a/src/PayPlugSyliusPayPlugPlugin.php b/src/PayPlugSyliusPayPlugPlugin.php
@@ -11,7 +11,7 @@ final class PayPlugSyliusPayPlugPlugin extends Bundle
 {
     use SyliusPluginTrait;
 
-    public const VERSION = '1.11.0';
+    public const VERSION = '2.x-dev';
 
     public function getPath(): string
     {

diff --git a/templates/javascripts/oney_common.html.twig b/templates/javascripts/oney_common.html.twig
diff --git a/templates/javascripts/select_payment_js.html.twig b/templates/javascripts/select_payment_js.html.twig
diff --git a/templates/javascripts/webfont_loader.html.twig b/templates/javascripts/webfont_loader.html.twig
diff --git a/templates/stylesheets/oney_common.html.twig b/templates/stylesheets/oney_common.html.twig
diff --git a/templates/stylesheets/payment_method_css.html.twig b/templates/stylesheets/payment_method_css.html.twig
diff --git a/templates/stylesheets/saved_cards.html.twig b/templates/stylesheets/saved_cards.html.twig
diff --git a/templates/stylesheets/select_payment_css.html.twig b/templates/stylesheets/select_payment_css.html.twig
diff --git a/translations/messages.en.yml b/translations/messages.en.yml
@@ -123,7 +123,7 @@ payplug_sylius_payplug_plugin:
         base_currency_not_euro: |
             Channel #channel_code#: #payment_method# is only available on channels with EURO as a currency
         only_one_gateway_allowed: |
-            Please note that the %gateway_title% payment method has already been set. To change it, go to your <a href="/admin/payment-methods/" target="_blank">payment methods</a>.
+            Please note that the %gateway_title% payment method has already been set. To change it, go to your payment methods.
         one_click_enable: Enable One click
         one_click_help: |
             Allow your customers to save their credit card details for later

diff --git a/translations/messages.fr.yml b/translations/messages.fr.yml
@@ -143,7 +143,7 @@ payplug_sylius_payplug_plugin:
         base_currency_not_euro: |
             Canal #channel_code# : #payment_method# n’est disponible que sur des canaux dont la devise est l’EURO
         only_one_gateway_allowed: |
-            Attention, le moyen de paiement %gateway_title% existe déjà. Pour le modifier, rendez-vous sur vos <a href="/admin/payment-methods/" target="_blank">moyens de paiement</a>.
+            Attention, le moyen de paiement %gateway_title% existe déjà. Pour le modifier, rendez-vous sur vos moyens de paiement.
         one_click_enable: Activer le One click
         one_click_help: |
             Permettez à vos clients d'enregistrer leurs coordonnées de carte de paiement pour effectuer ultérieurement

diff --git a/translations/messages.it.yml b/translations/messages.it.yml
@@ -123,7 +123,7 @@ payplug_sylius_payplug_plugin:
         base_currency_not_euro: |
             Il canale #channel_code# : #payment_method# è disponibile solo per i canali la cui valuta è in EURO
         only_one_gateway_allowed: |
-            Attenzione: il metodo di pagamento %gateway_title% è già definito. Per modificarlo, vai ai tuoi <a href="/admin/payment-methods/" target="_blank">metodi di pagamento</a>.
+            Attenzione: il metodo di pagamento %gateway_title% è già definito. Per modificarlo, vai ai tuoi metodi di pagamento.
         one_click_enable: Attiva un clic
         one_click_help: |
             Consenti ai tuoi clienti di salvare i dettagli della loro carta di credito per dopo
Original file line number	Diff line number	Diff line change
		@@ -1,2 +1 @@
		// Mandatory by test application
		// whereas it's useless