Skip to content

[MCP Bundle] Make MonologBundle optional #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camilleislasse wants to merge 6 commits into
base: main
Choose a base branch
from
+10 −26
Open

[MCP Bundle] Make MonologBundle optional #864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9fa5c11
Make MonologBundle optional in McpBundle
camilleislasse Nov 13, 2025
ecea6d6
Conditionally call Builder->setLogger() only when MonologBundle exi…
camilleislasse Nov 14, 2025
a8500ca
Add MonologBundle to require-dev to ensure tests run in CI
camilleislasse Nov 15, 2025
ddf1694
Simplify Transport instantiation with nullable logger
camilleislasse Nov 24, 2025
b920d78
Remove unnecessary markTestSkipped for MonologBundle
camilleislasse Dec 4, 2025
724a27e
Use generic logger service with monolog.logger tag
camilleislasse Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/mcp-bundle/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"require-dev": {
"phpstan/phpstan": "^2.1",
"phpstan/phpstan-strict-rules": "^2.0",
"phpunit/phpunit": "^11.5"
"phpunit/phpunit": "^11.5",
"symfony/monolog-bundle": "^3.10"
},
"minimum-stability": "dev",
"prefer-stable": true,
Expand Down
9 changes: 2 additions & 7 deletions src/mcp-bundle/config/services.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,18 @@

return static function (ContainerConfigurator $container): void {
$container->services()
->set('monolog.logger.mcp')
->parent('monolog.logger_prototype')
->args(['mcp'])
->tag('monolog.logger', ['channel' => 'mcp'])

->set('mcp.server.builder', Builder::class)
->factory([Server::class, 'builder'])
->call('setServerInfo', [param('mcp.app'), param('mcp.version')])
->call('setPaginationLimit', [param('mcp.pagination_limit')])
->call('setInstructions', [param('mcp.instructions')])
->call('setLogger', [service('monolog.logger.mcp')])
->call('setEventDispatcher', [service('event_dispatcher')])
->call('setSession', [service('mcp.session.store')])
->call('setDiscovery', [param('kernel.project_dir'), param('mcp.discovery.scan_dirs'), param('mcp.discovery.exclude_dirs')])
->call('setLogger', [service('logger')])
->tag('monolog.logger', ['channel' => 'mcp'])

->set('mcp.server', Server::class)
->factory([service('mcp.server.builder'), 'build'])

;
};
2 changes: 1 addition & 1 deletion src/mcp-bundle/src/Command/McpCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class McpCommand extends Command
{
public function __construct(
private readonly Server $server,
private readonly LoggerInterface $logger,
private readonly ?LoggerInterface $logger = null,
) {
parent::__construct();
}
Expand Down
9 changes: 5 additions & 4 deletions src/mcp-bundle/src/McpBundle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
use Symfony\Component\Config\Definition\Configurator\DefinitionConfigurator;
use Symfony\Component\DependencyInjection\ChildDefinition;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use Symfony\Component\DependencyInjection\Reference;
use Symfony\Component\HttpKernel\Bundle\AbstractBundle;
Expand Down Expand Up @@ -116,7 +115,8 @@ private function configureClient(array $transports, array $httpConfig, Container
new Reference('mcp.server'),
new Reference('logger'),
])
->addTag('console.command');
->addTag('console.command')
->addTag('monolog.logger', ['channel' => 'mcp']);
}

if ($transports['http']) {
Expand All @@ -127,10 +127,11 @@ private function configureClient(array $transports, array $httpConfig, Container
new Reference('mcp.http_foundation_factory'),
new Reference('mcp.psr17_factory'),
new Reference('mcp.psr17_factory'),
new Reference('monolog.logger.mcp', ContainerInterface::NULL_ON_INVALID_REFERENCE),
new Reference('logger'),
])
->setPublic(true)
->addTag('controller.service_arguments');
->addTag('controller.service_arguments')
->addTag('monolog.logger', ['channel' => 'mcp']);
}

$container->register('mcp.server.route_loader', RouteLoader::class)
Expand Down
13 changes: 0 additions & 13 deletions src/mcp-bundle/tests/DependencyInjection/McpBundleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,19 +47,6 @@ public function testCustomConfiguration()
$this->assertSame('This server provides weather and calendar tools', $container->getParameter('mcp.instructions'));
}

public function testMcpLoggerServiceIsCreated()
{
$container = $this->buildContainer([]);

$this->assertTrue($container->hasDefinition('monolog.logger.mcp'));

$definition = $container->getDefinition('monolog.logger.mcp');
$this->assertInstanceOf(\Symfony\Component\DependencyInjection\ChildDefinition::class, $definition);
$this->assertSame('monolog.logger_prototype', $definition->getParent());
$this->assertSame(['mcp'], $definition->getArguments());
$this->assertTrue($definition->hasTag('monolog.logger'));
}

#[DataProvider('provideClientTransportsConfiguration')]
public function testClientTransportsConfiguration(array $config, array $expectedServices)
{
Expand Down
Loading