Use Symfony 7.4 for demo, examples and ai.symfony.com #1013
+37
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
requested review from
javiereguiluz
and removed request for
chr-hertel
carsonbot
changed the title
Member
|
do we want to commit or add to gitignore? 
|
Member
|
The recommendation is to commit those |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Dec 5, 2025
…rStark) This PR was squashed before being merged into the 7.4 branch. Discussion ---------- [Config] Fix array shape generation for backed enums | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | -- | License | MIT Spotted in symfony/ai#1013 ➡️ https://github.com/symfony/ai/actions/runs/19780810683/job/56680686767?pr=1013 It works for `redis`, but not for `postgres`, because `redis` is using `->values(Distance::cases())` and `postgres` is using `->enumFqcn(PostgresDistance::class)`: ### Redis #### Enum ```php enum Distance: string { use Comparable; case Cosine = 'COSINE'; case L2 = 'L2'; case Ip = 'IP'; } ``` #### Config ```php ->enumNode('distance') ->info('Distance metric to use for vector similarity search') ->values(Distance::cases()) ->defaultValue(Distance::Cosine) ->end() ``` #### RESULT ```php * redis?: array<string, array{ // Default: [] * connection_parameters?: mixed, // see https://github.com/phpredis/phpredis?tab=readme-ov-file#example-1 * client?: string, // a service id of a Redis client * index_name: string, * key_prefix?: string, // Default: "vector:" * distance?: \Symfony\AI\Store\Bridge\Redis\Distance::Cosine|\Symfony\AI\Store\Bridge\Redis\Distance::L2|\Symfony\AI\Store\Bridge\Redis\Distance::Ip, // Distance metric to use for vector similarity search // Default: "COSINE" * }>, ``` ### Postgres #### Enum ```php enum Distance: string { use Comparable; case Cosine = 'cosine'; case InnerProduct = 'inner_product'; case L1 = 'l1'; case L2 = 'l2'; public function getComparisonSign(): string { return match ($this) { self::Cosine => '<=>', self::InnerProduct => '<#>', self::L1 => '<+>', self::L2 => '<->', }; } } ``` #### Config ```php ->enumNode('distance') ->info('Distance metric to use for vector similarity search') ->enumFqcn(PostgresDistance::class) ->defaultValue(PostgresDistance::L2) ->end() ``` #### RESULT ```php * postgres?: array<string, array{ // Default: [] * dsn?: string, * username?: string, * password?: string, * table_name: string, * vector_field?: string, * distance?: cosine|inner_product|l1|l2, // Distance metric to use for vector similarity search // Default: "l2" * dbal_connection?: string, * }>, ``` you can see, that the result is different: FQCN: `distance?: \Symfony\AI\Store\Bridge\Redis\Distance::Cosine|\Symfony\AI\Store\Bridge\Redis\Distance::L2|\Symfony\AI\Store\Bridge\Redis\Distance::Ip,` vs. strings: `distance?: cosine|inner_product|l1|l2,` Why? Commits ------- 62422c4 [Config] Fix array shape generation for backed enums
symfony-splitter
pushed a commit
to symfony/config
that referenced
this pull request
Dec 5, 2025
…rStark) This PR was squashed before being merged into the 7.4 branch. Discussion ---------- [Config] Fix array shape generation for backed enums | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | -- | License | MIT Spotted in symfony/ai#1013 ➡️ https://github.com/symfony/ai/actions/runs/19780810683/job/56680686767?pr=1013 It works for `redis`, but not for `postgres`, because `redis` is using `->values(Distance::cases())` and `postgres` is using `->enumFqcn(PostgresDistance::class)`: ### Redis #### Enum ```php enum Distance: string { use Comparable; case Cosine = 'COSINE'; case L2 = 'L2'; case Ip = 'IP'; } ``` #### Config ```php ->enumNode('distance') ->info('Distance metric to use for vector similarity search') ->values(Distance::cases()) ->defaultValue(Distance::Cosine) ->end() ``` #### RESULT ```php * redis?: array<string, array{ // Default: [] * connection_parameters?: mixed, // see https://github.com/phpredis/phpredis?tab=readme-ov-file#example-1 * client?: string, // a service id of a Redis client * index_name: string, * key_prefix?: string, // Default: "vector:" * distance?: \Symfony\AI\Store\Bridge\Redis\Distance::Cosine|\Symfony\AI\Store\Bridge\Redis\Distance::L2|\Symfony\AI\Store\Bridge\Redis\Distance::Ip, // Distance metric to use for vector similarity search // Default: "COSINE" * }>, ``` ### Postgres #### Enum ```php enum Distance: string { use Comparable; case Cosine = 'cosine'; case InnerProduct = 'inner_product'; case L1 = 'l1'; case L2 = 'l2'; public function getComparisonSign(): string { return match ($this) { self::Cosine => '<=>', self::InnerProduct => '<#>', self::L1 => '<+>', self::L2 => '<->', }; } } ``` #### Config ```php ->enumNode('distance') ->info('Distance metric to use for vector similarity search') ->enumFqcn(PostgresDistance::class) ->defaultValue(PostgresDistance::L2) ->end() ``` #### RESULT ```php * postgres?: array<string, array{ // Default: [] * dsn?: string, * username?: string, * password?: string, * table_name: string, * vector_field?: string, * distance?: cosine|inner_product|l1|l2, // Distance metric to use for vector similarity search // Default: "l2" * dbal_connection?: string, * }>, ``` you can see, that the result is different: FQCN: `distance?: \Symfony\AI\Store\Bridge\Redis\Distance::Cosine|\Symfony\AI\Store\Bridge\Redis\Distance::L2|\Symfony\AI\Store\Bridge\Redis\Distance::Ip,` vs. strings: `distance?: cosine|inner_product|l1|l2,` Why? Commits ------- 62422c43483 [Config] Fix array shape generation for backed enums
Member
|
Blocked by symfony/symfony patch release. |
Contributor
Author
7.4.1 just out now |
OskarStark
force-pushed
the
symfony-7.4-requirement
branch
from
78c9b68 to
f8a10c9
Compare
OskarStark
force-pushed
the
symfony-7.4-requirement
branch
from
f8a10c9 to
dd8ff21
Compare
Update all Symfony component requirements from 7.3 to 7.4 across demo, examples, ai.symfony.com, root composer.json, and GitHub workflow files. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
OskarStark
force-pushed
the
symfony-7.4-requirement
branch
from
dd8ff21 to
ab840cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs