Remove GUID.Wrapper from the WinSDK overlay.
#1436
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the `Equatable` and `Hashable` conformances for `GUID` have landed in the 6.3 toolchain, we can remove our wrapper workaround type. For the short term, we emit retroactive conformances to these protocols when using the 6.2 toolchain, but I'll remove those in short order.
grynspan
added
enhancement
grynspan
requested review from
briancroom,
jerryjrchen and
stmontgomery
as code owners
Contributor
Author
|
We can also hold off on this until we stop automerging to 6.3 so that main is 6.4(?) and we don't provide 6.2 support anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the
EquatableandHashableconformances forGUIDhave landed in the 6.3 toolchain (see swiftlang/swift#84792), we can remove our wrapper workaround type.For compatibility with the 6.2 toolchain, we emit retroactive conformances to these protocols when using a compiler < 6.3. These conformances aren't emitted as part of our toolchain build (CMake), only when building Swift Testing as a package on an older compiler. I'll remove the conformances when we drop 6.2 support.
This should have no other effects on the public-facing interface of the overlay.
Checklist: