Remove yet more uses of switch expressions

Author: DougGregor

Sources/SwiftRefactor/PackageManifest/AddTarget.swift

@@ -328,7 +328,7 @@ fileprivate extension TargetDescription.Dependency {
     case .target(name: let name),
       .byName(name: let name),
       .product(name: let name, package: _):
-      name
+      return name
     }
   }
 }

Sources/SwiftRefactor/PackageManifest/ManifestEditError.swift

@@ -25,13 +25,13 @@ extension ManifestEditError: CustomStringConvertible {
   public var description: String {
     switch self {
     case .cannotFindPackage:
-      "invalid manifest: unable to find 'Package' declaration"
+      return "invalid manifest: unable to find 'Package' declaration"
     case .cannotFindTargets:
-      "unable to find package targets in manifest"
+      return "unable to find package targets in manifest"
     case .cannotFindTarget(targetName: let name):
-      "unable to find target named '\(name)' in package"
+      return "unable to find target named '\(name)' in package"
     case .cannotFindArrayLiteralArgument(argumentName: let name, node: _):
-      "unable to find array literal for '\(name)' argument"
+      return "unable to find array literal for '\(name)' argument"
     }
   }
 }

Sources/SwiftRefactor/PackageManifest/PackageDependency.swift

@@ -68,9 +68,9 @@ public enum PackageDependency: Sendable {
 extension PackageDependency: ManifestSyntaxRepresentable {
   func asSyntax() -> ExprSyntax {
     switch self {
-    case .fileSystem(let filesystem): filesystem.asSyntax()
-    case .sourceControl(let sourceControl): sourceControl.asSyntax()
-    case .registry(let registry): registry.asSyntax()
+    case .fileSystem(let filesystem): return filesystem.asSyntax()
+    case .sourceControl(let sourceControl): return sourceControl.asSyntax()
+    case .registry(let registry): return registry.asSyntax()
     }
   }
 }

Sources/SwiftRefactor/PackageManifest/ProductDescription.swift

@@ -42,12 +42,12 @@ extension ProductDescription: ManifestSyntaxRepresentable {
   /// to check the precondition.
   private var functionName: String {
     switch type {
-    case .executable: "executable"
-    case .library(_): "library"
-    case .macro: "macro"
-    case .plugin: "plugin"
-    case .snippet: "snippet"
-    case .test: "test"
+    case .executable: return "executable"
+    case .library(_): return "library"
+    case .macro: return "macro"
+    case .plugin: return "plugin"
+    case .snippet: return "snippet"
+    case .test: return "test"
     }
   }
 

Sources/SwiftRefactor/PackageManifest/TargetDescription.swift

@@ -75,13 +75,13 @@ extension TargetDescription: ManifestSyntaxRepresentable {
   /// The function name in the package manifest.
   private var functionName: String {
     switch type {
-    case .binary: "binaryTarget"
-    case .executable: "executableTarget"
-    case .library: "target"
-    case .macro: "macro"
-    case .plugin: "plugin"
-    case .system: "systemLibrary"
-    case .test: "testTarget"
+    case .binary: return "binaryTarget"
+    case .executable: return "executableTarget"
+    case .library: return "target"
+    case .macro: return "macro"
+    case .plugin: return "plugin"
+    case .system: return "systemLibrary"
+    case .test: return "testTarget"
     }
   }