Remove more uses of switch expressions

Author: DougGregor

Sources/SwiftRefactor/PackageManifest/PackageDependency.swift

@@ -89,7 +89,7 @@ extension PackageDependency.SourceControl: ManifestSyntaxRepresentable {
     case .local:
       fatalError()
     case .remote(let url):
-      ".package(url: \(literal: url.description), \(requirement.asSyntax()))"
+      return ".package(url: \(literal: url.description), \(requirement.asSyntax()))"
     }
   }
 }
@@ -104,30 +104,30 @@ extension PackageDependency.SourceControl.Requirement: ManifestSyntaxRepresentab
   func asSyntax() -> LabeledExprSyntax {
     switch self {
     case .exact(let version):
-      LabeledExprSyntax(
+      return LabeledExprSyntax(
         label: "exact",
         expression: version.asSyntax()
       )
 
     case .rangeFrom(let range):
-      LabeledExprSyntax(
+      return LabeledExprSyntax(
         label: "from",
         expression: range.asSyntax()
       )
 
     case .range(let lowerBound, let upperBound):
-      LabeledExprSyntax(
+      return LabeledExprSyntax(
         expression: "\(lowerBound.asSyntax())..<\(upperBound.asSyntax())" as ExprSyntax
       )
 
     case .revision(let revision):
-      LabeledExprSyntax(
+      return LabeledExprSyntax(
         label: "revision",
         expression: "\(literal: revision)" as ExprSyntax
       )
 
     case .branch(let branch):
-      LabeledExprSyntax(
+      return LabeledExprSyntax(
         label: "branch",
         expression: "\(literal: branch)" as ExprSyntax
       )
@@ -139,19 +139,19 @@ extension PackageDependency.Registry.Requirement: ManifestSyntaxRepresentable {
   func asSyntax() -> LabeledExprSyntax {
     switch self {
     case .exact(let version):
-      LabeledExprSyntax(
+      return LabeledExprSyntax(
         label: "exact",
         expression: version.asSyntax()
       )
 
     case .rangeFrom(let range):
-      LabeledExprSyntax(
+      return LabeledExprSyntax(
         label: "from",
         expression: range.asSyntax()
       )
 
     case .range(let lowerBound, let upperBound):
-      LabeledExprSyntax(
+      return LabeledExprSyntax(
         expression: "\(lowerBound.asSyntax())..<\(upperBound.asSyntax())" as ExprSyntax
       )
     }

Sources/SwiftRefactor/PackageManifest/TargetDescription.swift

@@ -115,16 +115,16 @@ extension TargetDescription.Dependency: ManifestSyntaxRepresentable {
   func asSyntax() -> ExprSyntax {
     switch self {
     case .byName(name: let name):
-      "\(literal: name)"
+      return "\(literal: name)"
 
     case .target(name: let name):
-      ".target(name: \(literal: name))"
+      return ".target(name: \(literal: name))"
 
     case .product(name: let name, package: nil):
-      ".product(name: \(literal: name))"
+      return ".product(name: \(literal: name))"
 
     case .product(name: let name, package: let package):
-      ".product(name: \(literal: name), package: \(literal: package))"
+      return ".product(name: \(literal: name), package: \(literal: package))"
     }
   }
 }
@@ -133,10 +133,10 @@ extension TargetDescription.PluginUsage: ManifestSyntaxRepresentable {
   func asSyntax() -> ExprSyntax {
     switch self {
     case .plugin(name: let name, package: nil):
-      ".plugin(name: \(literal: name))"
+      return ".plugin(name: \(literal: name))"
 
     case .plugin(name: let name, package: let package):
-      ".plugin(name: \(literal: name), package: \(literal: package))"
+      return ".plugin(name: \(literal: name), package: \(literal: package))"
     }
   }
 }