-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Capture code snippet from diagnostic compiler output #9362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bripeticca
wants to merge
31
commits into
swiftlang:main
Choose a base branch
from
bripeticca:swb/diagnosticcodesnippet
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,237
−199
Open
Changes from 16 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
235dd3e
Forray into capturing swift compiler output logs
bripeticca f9dfdf3
Revert usage of JSON parser; selectively emit DiagnosticInfo
bripeticca b1ff231
Implement per-task-buffer of Data output
bripeticca ac6b81b
Fallback to locationContext if locationContext2 properties are nil
bripeticca 1ae0f38
Merge branch 'main' into swb/diagnosticcodesnippet
bripeticca b81bfca
Cleanup; add descriptions related to redundant task output
bripeticca f3aaabf
attempt to parse decoded string into individual diagnostics
bripeticca c48e606
cleanup
bripeticca f14600c
Revert diagnostic parsing and emit directly to outputStream
bripeticca 359331a
Address PR comments
bripeticca 56f0a45
implement generic print method for observability scope
bripeticca dd1505a
Introduce model to store data buffer per task type
bripeticca 08306e2
minor changes to TaskDataBuffer + cleanup
bripeticca 424492f
Modify emission of command line display strings
bripeticca 4074c59
cleanup; stronger assertions for redundant task output
bripeticca 05ee043
Fix protocol adherence errors
bripeticca 252286b
Create test suite for SwiftBuildSystemMessageHandler
bripeticca a658f58
Modify test mocks using exposed memberwise inits
bripeticca 7a00f35
Address PR comments
bripeticca e88ab96
Fix check on global task for LocationContext
bripeticca 5f0911d
Track serialized diagnostic path by targetID
bripeticca 8f713a0
Merge branch 'main' into swb/diagnosticcodesnippet
bripeticca fd21a42
Add FIXME + richer model to track emitted tasks
bripeticca 7a91843
Merge branch 'main' into swb/diagnosticcodesnippet
bripeticca 4e29267
Add documentation
bripeticca 45dc48c
Merge branch 'main' into swb/diagnosticcodesnippet
bripeticca f5dd65c
remove old print method
bripeticca 11d3945
Merge branch 'swb/diagnosticcodesnippet' into swb/messagehandlertests
bripeticca 30fc79a
Create new testing observability system that can be supplied an outpu…
bripeticca 91ee284
minor fixes to tests to account for logging changes
bripeticca 2a4c33a
test fixes
bripeticca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call this
func print(_ output: String, verbose: Bool)instead? Since we already have a viable implementation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's the
DiagnosticHandlersresponsibility to print the diagnostic here. We should instead have a "LoggingHandler" which would know where to emit the "message", whether it's to stdout, stderr, to a file, or some other place.