remove a few deprecated apis (#3653)

motivation: cleanup deprecated methods

changes: remove apis deprecated 6m+ ago

Author: tomerd

Sources/PackageLoading/ManifestLoader.swift

@@ -157,43 +157,6 @@ public final class ManifestLoader: ManifestLoaderProtocol {
         self.operationQueue.maxConcurrentOperationCount = Concurrency.maxOperations
     }
 
-    // deprecated 3/21, remove once clients migrated over
-    @available(*, deprecated, message: "use loadRootManifest instead")
-    public static func loadManifest(
-        at path: AbsolutePath,
-        kind: PackageReference.Kind,
-        swiftCompiler: AbsolutePath,
-        swiftCompilerFlags: [String],
-        identityResolver: IdentityResolver,
-        on queue: DispatchQueue,
-        completion: @escaping (Result<Manifest, Error>) -> Void
-    ) {
-        do {
-            let fileSystem = localFileSystem
-            let resources = try UserManifestResources(swiftCompiler: swiftCompiler, swiftCompilerFlags: swiftCompilerFlags)
-            let loader = ManifestLoader(manifestResources: resources)
-            let toolsVersion = try ToolsVersionLoader().load(at: path, fileSystem: fileSystem)
-            let packageLocation = path.pathString
-            let packageIdentity = identityResolver.resolveIdentity(for: packageLocation)
-            loader.load(
-                at: path,
-                packageIdentity: packageIdentity,
-                packageKind: kind,
-                packageLocation: packageLocation,
-                version: nil,
-                revision: nil,
-                toolsVersion: toolsVersion,
-                identityResolver: identityResolver,
-                fileSystem: fileSystem,
-                diagnostics: nil,
-                on: queue,
-                completion: completion
-            )
-        } catch {
-            return completion(.failure(error))
-        }
-    }
-
     /// Loads a root manifest from a path using the resources associated with a particular `swiftc` executable.
     ///
     /// - Parameters:
@@ -238,36 +201,6 @@ public final class ManifestLoader: ManifestLoaderProtocol {
         }
     }
 
-    // deprecated 3/21, remove once clients migrated over
-    @available(*, deprecated, message: "use load(at: packageIdentity:, ...) variant instead")
-    public func load(
-        at path: AbsolutePath,
-        packageKind: PackageReference.Kind,
-        packageLocation: String,
-        version: Version?,
-        revision: String?,
-        toolsVersion: ToolsVersion,
-        identityResolver: IdentityResolver,
-        fileSystem: FileSystem,
-        diagnostics: DiagnosticsEngine? = nil,
-        on queue: DispatchQueue,
-        completion: @escaping (Result<Manifest, Error>) -> Void
-    ) {
-        let packageIdentity = identityResolver.resolveIdentity(for: packageLocation)
-        self.load(at: path,
-                  packageIdentity: packageIdentity,
-                  packageKind: packageKind,
-                  packageLocation: packageLocation,
-                  version: version,
-                  revision: revision,
-                  toolsVersion: toolsVersion,
-                  identityResolver: identityResolver,
-                  fileSystem: fileSystem,
-                  diagnostics: diagnostics,
-                  on: queue,
-                  completion: completion)
-    }
-
     public func load(
         at path: AbsolutePath,
         packageIdentity: PackageIdentity,

Sources/PackageLoading/PackageBuilder.swift

@@ -287,41 +287,6 @@ public final class PackageBuilder {
         self.warnAboutImplicitExecutableTargets = warnAboutImplicitExecutableTargets
     }
 
-    // deprecated 3/21, remove once clients migrated over
-    @available(*, deprecated, message: "use loadRootPackage instead")
-    public static func loadPackage(
-        at path: AbsolutePath,
-        kind: PackageReference.Kind = .root,
-        swiftCompiler: AbsolutePath,
-        swiftCompilerFlags: [String],
-        xcTestMinimumDeploymentTargets: [PackageModel.Platform:PlatformVersion]
-            = MinimumDeploymentTarget.default.xcTestMinimumDeploymentTargets,
-        identityResolver: IdentityResolver,
-        diagnostics: DiagnosticsEngine,
-        on queue: DispatchQueue,
-        completion: @escaping (Result<Package, Error>) -> Void
-    ) {
-        ManifestLoader.loadManifest(at: path,
-                                    kind: kind,
-                                    swiftCompiler: swiftCompiler,
-                                    swiftCompilerFlags: swiftCompilerFlags,
-                                    identityResolver: identityResolver,
-                                    on: queue) { result in
-            let result = result.tryMap { manifest -> Package in
-                let identity = identityResolver.resolveIdentity(for: manifest.packageLocation)
-                let builder = PackageBuilder(
-                    identity: identity,
-                    manifest: manifest,
-                    productFilter: .everything,
-                    path: path,
-                    xcTestMinimumDeploymentTargets: xcTestMinimumDeploymentTargets,
-                    diagnostics: diagnostics)
-                return try builder.construct()
-            }
-            completion(result)
-        }
-    }
-
     /// Loads a root package from a path using the resources associated with a particular `swiftc` executable.
     ///
     /// - Parameters:

Sources/Workspace/Workspace.swift

@@ -619,19 +619,6 @@ extension Workspace {
         return nil
     }
 
-
-    // deprecated 3/21, remove once clients migrated over
-    @available(*, deprecated, message: "use loadRootPackage instead")
-    public static func loadGraph(
-        packagePath: AbsolutePath,
-        swiftCompiler: AbsolutePath,
-        swiftCompilerFlags: [String],
-        identityResolver: IdentityResolver,
-        diagnostics: DiagnosticsEngine
-    ) throws -> PackageGraph {
-        return try Self.loadRootGraph(at: packagePath, swiftCompiler: swiftCompiler, swiftCompilerFlags: swiftCompilerFlags, identityResolver: identityResolver, diagnostics: diagnostics)
-    }
-
     /// Loads a package graph from a root package using the resources associated with a particular `swiftc` executable.
     ///
     /// - Parameters: