feat: svelte head body separation for nested components in <svelte:head> tag #17324
+121
−237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix server-side rendering (SSR) by creating a capture renderer in the head() function that only pushes head content to the parent renderer, discarding body output - Add collect_sync() public method to Renderer for synchronous content collection - Fix client-side rendering (CSR) by filtering non-head-specific elements after rendering in head blocks, moving body elements (div, span, etc.) to the body while keeping head-specific elements (script, meta, link, style, title, etc.) in the head This ensures that when a component with both <svelte:head> and body content is placed inside a parent <svelte:head>, only the nested component's head content appears in the document head, and body content correctly appears in the document body. Fixes: Components rendering inside svelte:head had body content leaking into head section
…re moved to body if the nested component has any
🦋 Changeset detectedLatest commit: e8f6c10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Contributor
Author
|
Playground with fix |
7nik
reviewed
Dec 7, 2025
|
|
||
| block(() => render_fn(anchor), HEAD_EFFECT); | ||
|
|
||
| // After rendering, check if non-head elements were added and move them to body |
Contributor
There was a problem hiding this comment.
I very doubt this logic makes sense. Aside from "Why do you mix head and body elements?", these elements became un-cleanable in case the component/head is wrapped in #if or something else dynamic. And probably breaks other blocks like #each.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lintthis PR fixes 9163