Fix TypeScript generic parameters being stripped with Prettier 3.7.0+ #507
+121
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettier 3.7.0+ strips TypeScript generic parameters from expressions in Svelte templates:
Changes
Use
babel-ts/babelparsers directly instead of custom AST-manipulating parsers. The custom parsers extracted just the expression node from the AST, which became incompatible with Prettier 3.7.0's formatting engine.Add
removeLeadingSemicolonhelper to strip protective semicolons that Prettier adds for ASI protection (e.g.,;('foo')→'foo')Update
removeParentheseswith conservative heuristics to remove wrapper parentheses while preserving semantically important ones in function calls and grouped expressionsTrade-off
Using
babel-tsdirectly means Prettier removes some parentheses it considers unnecessary (e.g.,(x = !x)→x = !x). These are functionally equivalent but stylistically different. 9 existing tests reflect this formatting change.Testing
Verified with Prettier 3.0.0, 3.7.0, and 3.7.3. Generic parameters now preserved correctly while maintaining backward compatibility.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/prettier/prettier/compare/3.6.2...3.7.0/usr/bin/curl curl -s REDACTED(http block)prettier.io/usr/bin/curl curl -s REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.