Design 2 solutions #2428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

dbkuppagiri wants to merge 1 commit into super30admin:master from dbkuppagiri:master

dbkuppagiri commented Jan 7, 2026

No description provided.


          design 2 solutions

b2a2cd5

Owner

super30admin commented Jan 8, 2026

Strengths:

Good use of two stacks to implement the queue functionality.
Clear and readable code with appropriate comments.
Correct implementation of the push and empty methods.

Areas for Improvement:

The peek method should handle the case when both stacks are empty (e.g., return -1 or throw an error).
The pop method should check if the queue is empty before attempting to pop (similar to the reference solution).
Consider adding more detailed comments about the time complexity of each method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet