-
Notifications
You must be signed in to change notification settings - Fork 475
Fix DeprecationWarning when encoding StripeObject metadata (fixes #1651) #1687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ramya-stripe
merged 8 commits into
stripe:master
from
praniketkw:fix-metadata-deprecation-warning
Dec 23, 2025
Merged
Fix DeprecationWarning when encoding StripeObject metadata (fixes #1651) #1687
ramya-stripe
merged 8 commits into
stripe:master
from
praniketkw:fix-metadata-deprecation-warning
Dec 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-stripe
reviewed
Dec 9, 2025
Contributor
|
@praniketkw Can you also update the PR description based on the new approach? |
Contributor
Author
|
@ramya-stripe Done! |
ramya-stripe
approved these changes
Dec 23, 2025
Contributor
|
@praniketkw Thanks for your work on this. Can you update the PR description to reflect the final approach we have taken here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1651
Why?
When updating metadata on resources like invoices, users encountered a DeprecationWarning even though they were using the public API correctly. The warning was triggered internally when the encoder checked for the deprecated stripe_id property on StripeObject instances. While the deprecation warning serves an important purpose for direct user access to stripe_id, it should not be shown for internal library usage.
What?