Skip to content

Conversation

@ramya-stripe
Copy link
Contributor

Why?

func_get_args has incompatibility issues with PHP 8.0 originally reported in #1739. While we stopped using it a year ago in the library, we still used it in tests.

What?

Avoid using func_get_args

@ramya-stripe ramya-stripe requested a review from a team as a code owner September 26, 2025 19:34
@ramya-stripe ramya-stripe requested review from helenye-stripe and prathmesh-stripe and removed request for a team September 26, 2025 19:34
@navagj0
Copy link

navagj0 commented Jan 6, 2026

From 9a3b254 Mon Sep 17 00:00:00 2001
From: Ramya Rao ramya@stripe.com
Date: Fri, 26 Sep 2025 12:32:07 -0700
Subject: [PATCH] Avoid using func_get_args


tests/Stripe/HttpClient/CurlClientTest.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/Stripe/HttpClient/CurlClientTest.php b/tests/Stripe/HttpClient/CurlClientTest.php
index 3479627cc..5bd714c56 100644
--- a/tests/Stripe/HttpClient/CurlClientTest.php
+++ b/tests/Stripe/HttpClient/CurlClientTest.php
@@ -147,7 +147,7 @@ public function testDefaultOptions()
// make sure closure-based options work properly, including argument passing
$ref = null;
$withClosure = new CurlClient(static function ($method, $absUrl, $headers, $params, $hasFile) use (&$ref) {

  •        $ref = \func_get_args();
    
  •        $ref = [$method, $absUrl, $headers, $params, $hasFile];
    
           return [];
       });
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants