Skip to content

Conversation

@jiangpengcheng
Copy link
Member

When functions has multiple replicas, the filebeat will use the name as the producer name, which cause conflicts

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@jiangpengcheng jiangpengcheng requested review from a team, freeznet and nlu90 as code owners August 8, 2025 09:56
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Aug 8, 2025
shibd
shibd previously approved these changes Aug 8, 2025
RobertIndie
RobertIndie previously approved these changes Aug 8, 2025
@jiangpengcheng jiangpengcheng dismissed stale reviews from RobertIndie and shibd via cee627e August 11, 2025 01:01
@jiangpengcheng jiangpengcheng merged commit 8262682 into master Aug 14, 2025
13 checks passed
@jiangpengcheng jiangpengcheng deleted the use_pod_name_as_name_for_filebeat branch August 14, 2025 09:21
jiangpengcheng added a commit that referenced this pull request Aug 18, 2025
* Use POD_NAME as the name for filebeat sidecar container

* Upgrade go to 1.24.6

* Fix style
jiangpengcheng added a commit that referenced this pull request Aug 18, 2025
* Use POD_NAME as the name for filebeat sidecar container

* Upgrade go to 1.24.6

* Fix style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-need-doc This pr does not need any document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants