FIX: Handle empty response bodies #36
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
insertish
reviewed
Aug 29, 2025
Contributor
There was a problem hiding this comment.
I think a better solution is to just check:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Content-Lengthnot present in HTTP/2 (or it requires some extra work? https://stackoverflow.com/a/48266945 -- either way more complicated than:)status === 204
Comment on lines
-208
to
+227
| const data = await fetchdata[config?.responseType || "json"](); | ||
| let data: any; | ||
| const text = await fetchdata.text(); | ||
| if (text) { | ||
| switch (config?.responseType || "json") { | ||
| case "json": | ||
| data = JSON.parse(text); | ||
| break; | ||
| case "text": | ||
| data = text; | ||
| break; | ||
| case "blob": | ||
| data = new Blob([text]); | ||
| break; | ||
| case "arrayBuffer": | ||
| data = new TextEncoder().encode(text).buffer; | ||
| break; | ||
| } | ||
| } else { | ||
| data = null; | ||
| } |
Contributor
There was a problem hiding this comment.
I think the blob/arrayBuffer cases (although not used) are prone to error here.
I'm not sure if it's a good idea to go straight to text..
Contributor
|
I guess the patch should also go to https://github.com/insertish/oapi so I will apply the fix using 204 check. |
github-project-automation
bot
moved this from 🆕 Untriaged
to Closed
in Pull Request Overview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the API client would throw a JSON parse error if a response body was empty, this checks for that and handles it without throwing an error – fixes the bug reported on frontend repo here
Please make sure to check the following tasks before opening and submitting a PR
↑ Unable to test it locally