Shellcheck: Fix unescaped vars #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes various unescaped vars in shellcheck which are currently failing the CI. This doesn't address the remaining warnings about usage of sudo, as we can combine "usermod -aG" with "newgrp" to avoid having to restart the session
Collaborator
Author
|
@khalford Could you pick up the |
Using tee here as sudo doesn't affect redirects and is causing shellcheck to raise a flag. We can add the user to the microk8s group to avoid sudo but this requires a new session and would be complicated to add into the script considering we only use microk8s for the bootstrapping and then get rid of it.
Member
Unfortunately |
khalford
approved these changes
Jan 8, 2026
meoflynn
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various unescaped vars in shellcheck which are currently failing the CI.
This doesn't address the remaining warnings about usage of sudo, as we can combine "usermod -aG" with "newgrp" to avoid having to restart the session