-
-
Notifications
You must be signed in to change notification settings - Fork 26
Add Lithuanian language support (lt) #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@LookNowThis thanks for this!! I just realized yesterday I forgot to copy the current Lithuanian translations to that Python file. Would you mind making the translations consistent between that CSV and the Python dictionary? |
| def language_name_column(language: str, column_prefix: str = "name") -> str: | ||
| language_name = language.replace("-", "_").lower() | ||
|
|
||
| return f"{column_prefix}_{language_name}" | ||
|
|
||
|
|
||
| def translate(text: str, language: str) -> str: | ||
| if not text: | ||
| return text | ||
|
|
||
| translation = LABELS[language.lower()].get(text.lower()) | ||
|
|
||
| if not translation: | ||
| return text | ||
|
|
||
| return translation.title() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add these functions back? They're important for using the translations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I’ve added both functions back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! did you see my other comment about making the translations consistent between that CSV and the Python dictionary in this file? I noticed there's a few differences, and unfortunately I don't know Lithuanian to make an educated guess. Would greatly appreciate your help!
Added translation functions for language handling.
|
I updated lithuanian terms in csv file. Could you please use official lt terminology rather than literal translations of LookNowThis. Refer to the linked respectful lt terminology sources in the enclosed txt file for guidance (if any doubt). Thanks for your efforts. Merry Christmas.
Sincerely
ex_scopus
Sent from [Proton Mail](https://proton.me/mail/home) for Android.
…-------- Original Message --------
On Monday, 12/22/25 at 00:54 Steve Berardi ***@***.***> wrote:
Merged [#201](#201) into main.
—
Reply to this email directly, [view it on GitHub](#201 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BOCMT372H4QK6ZSMVO6UBEL4C4QLNAVCNFSM6AAAAACPKEBLXGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRRGY4TGMJQGI4TIOI).
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
@zodiakas can you post the link to the TXT file you're referring to? I'm certainly happy to use the most accepted translations, so if you have a reference from some astronomical society / org or something, that'll help confirm that's the best translation. Thanks!! And, Merry Christmas to you too! 🎄 -Steve |
|
The reference file:
https://github.com/zodiakas/starplot/blob/main/data/raw/translations/lt/LT_reference.txt
It is included into my github request to modify your main as well.
The main open source for lt terminology is National encyclopedia online (vle.lt), but I added links to the bank of terminology (used mainly for legal documents), etc. I also have a printed encyclopedic vocabulary of astronomy in Lithuanian (V. Straižys. Astronomijos enciklopedinis žodynas. - Vilnius, Teorinės fizikos ir astronomijos institutas) as well as few printed lt astronomical books, aproved nationaly for high school students – would be happy to double check lt terms if any doubt.
Sincerely
ex_scopus
Sent from [Proton Mail](https://proton.me/mail/home) for Android.
…-------- Original Message --------
On Thursday, 12/25/25 at 19:04 Steve Berardi ***@***.***> wrote:
steveberardi left a comment [(steveberardi/starplot#201)](#201 (comment))
> I updated lithuanian terms in csv file. Could you please use official lt terminology rather than literal translations of LookNowThis. Refer to the linked respectful lt terminology sources in the enclosed txt file for guidance (if any doubt). Thanks for your efforts. Merry Christmas.
***@***.***(https://github.com/zodiakas) can you post the link to the TXT file you're referring to? I'm certainly happy to use the most accepted translations, so if you have a reference from some astronomical society / org or something, that'll help confirm that's the best translation. Thanks!! And, Merry Christmas to you too! 🎄 -Steve
—
Reply to this email directly, [view it on GitHub](#201 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BOCMT354JVPXRAMYFCMSOOD4DQKKFAVCNFSM6AAAAACPKEBLXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMOJRGYYDMNZRGA).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@zodiakas great, thanks for providing that info. I'll include your originally submitted translations for the other terms in the next version of Starplot, v0.18 -- which should be out in the next week or two. I think I'll also start requesting translation sources for future translations, just to help be sure that we use the best translation. Thanks again! |
Added Lithuanian (lt) translations to Starplot:
This improves localization coverage and adds support for Lithuanian users.