Optimize startup performance and eliminate UI lag #131
Conversation
…ckground tasks\n\n- Move keychain migration to a detached background task\n- Make path debug info resolution async and deferred\n- Implement lazy initialization for NSStatusItems to reduce IPC overhead on startup\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)\n\nCo-Authored-By: Claude <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9631e0ef3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| Task.detached(priority: .userInitiated) { [weak self] in | ||
| await self?.refreshPathDebugInfo() | ||
| } | ||
| LoginShellPathCache.shared.captureOnce { [weak self] _ in | ||
| Task { @MainActor in self?.refreshPathDebugInfo() } | ||
| Task { @MainActor in |
There was a problem hiding this comment.
The new async refresh runs twice with no ordering: a detached refreshPathDebugInfo() starts immediately (before LoginShellPathCache has a value), and then captureOnce triggers a second refresh after the login PATH is captured. Because both tasks race, the first (potentially slow) refresh can finish after the login-PATH refresh and overwrite pathDebugInfo with a snapshot that has loginShellPATH/binary paths missing. This shows up in the Debug preferences as missing binaries or empty login PATH when shell resolution is slow. Consider gating the early refresh, canceling it when captureOnce finishes, or only overwriting when the snapshot includes loginShellPATH.
Useful? React with 👍 / 👎.
1 participant
Summary
This PR addresses UI lag and responsiveness issues during app startup by moving several blocking operations from the main thread to background tasks.
Key Changes
UsageStorenow resolves binary paths (which involves spawning interactive shells) in a detached background task.KeychainMigration.migrateIfNeeded()to an async task inHiddenWindowViewto prevent blocking the app'sinit.StatusItemControllerto createNSStatusItems only when needed (lazily), reducing IPC overhead with the system status bar during launch.@MainActor.Test plan
./Scripts/compile_and_run.shwithCODEXBAR_SIGNING=adhocto verify local execution.🤖 Generated with Claude Code