Fix too early task removal and startup conditions #8
Conversation
mpulukkinen
commented
Dec 8, 2025
mpulukkinen
commented
- Remove the task only after completed and client polls the result
- Remove the exit's when there's parameters that are not needed for server
- No longer exits if non-required parameters are missing
- Only erase when client polls the result and task is failed or done
|
The reason I was erasing the data (which is the preview or final image) after sending the result was to avoid spamming the same image data multiple times over the network, so the client can assume that if it receives no data, the last image received is the lastest. Maybe there's another way to achieve the same without dropping the data. Was the current implementation causing issues? |
|
Yeah, at least at first, because my app (usually) polls the result. So I was getting null result back and was very confused. Also, I was not getting the current progress. The task gives out the step and max steps, so I was using it to show progress. I wouldn't be so concerned about the preview data being transferred... Maybe the preview data could be cleared every time the result is sent? That way we could have best of the both worlds? :) |
Isn't that what the current implementation already does? |
|
I think removing the unnecessary parameters is a good change, not convinced yet about the other thing |
Yeah but it cleared all the results for the task (id) and next poll would give just null response to the client, which confused me a lot. In general, the servers should not send null results since the clients can't really know what's going on... |
|
Also, I'd like to add that from the client side point of view, it is difficult to know what's the actual situation if server sends null response: did the server crash? Did I just send wrong task id? Was the endpoint unreachable etc... |
2 participants
