[RandomButton] Correct random sort logic #650
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no sort field is specified in GraphQL the server defaults to date created (descending). This incorrectly weighs the random sort results which creates bias towards newer content. Adding the random sort field corrects this.
Contributor
Author
|
Tested locally without issue. I used the date created field for verification. Before, it heavily favors newer dates. With this change it seems to be truly random now. |
DogmaDragon
changed the title
|
This pull request has been mentioned on Stash. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no sort field is specified in GraphQL the server defaults to date created (descending). This incorrectly weighs the random sort results which creates bias towards newer content.
Adding the random sort field corrects this.