feat: add enableServiceLinks support to Deployment

README.md

@@ -88,6 +88,7 @@ helm delete --namespace test my-application
 | deployment.image.pullPolicy | string | `"IfNotPresent"` | Image pull policy. |
 | deployment.dnsConfig | object | `nil` | DNS config for the pods. |
 | deployment.dnsPolicy | string | `""` | DNS Policy. |
+| deployment.enableServiceLinks | bool | `true` | Enable Kubernetes service links. |
 | deployment.startupProbe | object | See below | Startup probe. Must specify either one of the following field when enabled: httpGet, exec, tcpSocket, grpc |
 | deployment.startupProbe.enabled | bool | `false` | Enable Startup probe. |
 | deployment.startupProbe.failureThreshold | int | `30` | Number of retries before marking the pod as failed. |

application/templates/deployment.yaml

@@ -75,6 +75,7 @@ spec:
           ]
 {{- end }}
     spec:
+      enableServiceLinks: {{ .Values.deployment.enableServiceLinks }}
       {{- with .Values.deployment.hostAliases }}
       hostAliases: {{- toYaml . | nindent 6 }}
       {{- end }}

application/tests/deployment_test.yaml

@@ -134,6 +134,20 @@ tests:
           path: spec.template.spec.containers[0].livenessProbe.grpc.port
           value: 5000
 
+  - it: configures enable service links by default
+    asserts:
+      - equal:
+          path: spec.template.spec.enableServiceLinks
+          value: true
+
+  - it: disable enable service links when configured
+    set:
+      deployment.enableServiceLinks: false
+    asserts:
+      - equal:
+          path: spec.template.spec.enableServiceLinks
+          value: false
+
   - it: configures envFrom as mandatory by default
     set:
       deployment.envFrom:

application/values.yaml

@@ -304,6 +304,9 @@ deployment:
   # -- (string) DNS Policy.
   # @section -- Deployment Parameters
   dnsPolicy: ""
+  # -- (bool) Enable Kubernetes service links.
+  # @section -- Deployment Parameters
+  enableServiceLinks: true
   # -- (object) Startup probe.
   # @default -- See below
   # Must specify either one of the following field when enabled: httpGet, exec, tcpSocket, grpc