Skip to content

fix: Add test for resource name pattern matching #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aslafy-z wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: Add test for resource name pattern matching #466

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5cb5c7
fix: Add test for resource name pattern matching
aslafy-z Oct 28, 2025
72ca52f
Add tests for valid resource name rendering
aslafy-z Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions application/tests/common_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,34 @@ x-keys:
skipEmptyTemplates: true

tests:
- it: should render valid resource names using default release name
set:
applicationName: ""
asserts:
- matchRegex:
path: metadata.name
pattern: ^RELEASE-NAME(?:-.+)?$

- it: should render valid resource names using actual release name
set:
applicationName: ""
release:
name: myapp
asserts:
- matchRegex:
path: metadata.name
pattern: ^myapp(?:-.+)?$

- it: should render valid resource names when applicationName is set
set:
applicationName: myapp
release:
name: whatever
asserts:
- matchRegex:
path: metadata.name
pattern: ^myapp(?:-.+)?$

- it: Default common labels
documentSelector:
<<: *x-documentSelector
Expand Down
Loading