Skip to content

feat!: drop default part-of label, require explicit override #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aslafy-z wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat!: drop default part-of label, require explicit override #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9eb667
feat!: drop default part-of label, require explicit override
aslafy-z Oct 1, 2025
f85e8c0
Remove check for 'app.kubernetes.io/part-of' label
aslafy-z Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions application/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,6 @@ app.kubernetes.io/component: {{ .Values.componentOverride }}
{{- end }}
{{- if .Values.partOfOverride }}
app.kubernetes.io/part-of: {{ .Values.partOfOverride }}
{{- /* TODO: obsolete else case on major bump (?) */}}
{{- else }}
app.kubernetes.io/part-of: {{ include "application.name" . }}
{{- end }}
{{- include "application.additionalLabels" . }}
{{- end }}
Expand Down
3 changes: 0 additions & 3 deletions application/tests/common_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,6 @@ tests:
value: image-tag
- notExists:
path: metadata.labels["app.kubernetes.io/component"]
- equal:
path: metadata.labels["app.kubernetes.io/part-of"]
value: application

- it: Common labels
documentSelector:
Expand Down
Loading