Skip to content

Conversation

@aslafy-z
Copy link
Collaborator

@aslafy-z aslafy-z commented Nov 15, 2024

Closes #320
Closes #361

  • BREAKING: Rename rbac.serviceAccount.enabled field to rbac.serviceAccount.create.

  • Fix inconsistencies in serviceAccount binding across CronJob, Job, and Deployment templates by introducing a new application.serviceAccountName template:

    rbac.serviceAccount.create rbac.serviceAccount.name result
    true "" (include "application.name" .)
    true "foo" "foo"
    false "" "default"
    false "bar" "bar"
  • Add field automountServiceAccountToken in pod specs controlled by rbac.enabled.

  • Document missing Role and RoleBinding rbac.annotations and rbac.additionalLabels fields.

@aslafy-z aslafy-z force-pushed the aslafy-z-patch-3 branch 2 times, most recently from 0ef820d to 7d495fb Compare November 15, 2024 12:05
@aslafy-z aslafy-z requested a review from d3adb5 November 15, 2024 12:07
Copy link
Collaborator

@d3adb5 d3adb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. I like the idea of adding a semantic value like this, but I feel the way it currently is introduces more confusion than clarity. I expanded upon this in one of the threads I opened below.

@aslafy-z aslafy-z force-pushed the aslafy-z-patch-3 branch 4 times, most recently from 4662e88 to a6b974e Compare January 22, 2025 19:21
@aslafy-z aslafy-z changed the title feat: allow usage of existing service account feat!: allow usage of existing service account Jan 22, 2025
@aslafy-z aslafy-z changed the title feat!: allow usage of existing service account feat!: allow usage of existing service account #major Jan 22, 2025
@aslafy-z aslafy-z changed the title feat!: allow usage of existing service account #major feat!: harmonize service account binding #major Jan 22, 2025
@aslafy-z aslafy-z requested a review from d3adb5 January 22, 2025 19:33
@aslafy-z aslafy-z marked this pull request as ready for review January 22, 2025 19:35
Copy link
Collaborator

@d3adb5 d3adb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final set of comments, I promise. Reminder to add a unit test for it if you do take the suggestion. Otherwise, LGTM.

@rasheedamir
Copy link
Member

@aslafy-z lets finalize and get this merged

@aslafy-z aslafy-z force-pushed the aslafy-z-patch-3 branch from fb0c8ba to 0efceb9 Compare May 15, 2025 08:14
@aslafy-z aslafy-z requested a review from d3adb5 May 15, 2025 08:17
@aslafy-z aslafy-z changed the title feat!: harmonize service account binding #major feat!: harmonize service account binding May 15, 2025
@aslafy-z
Copy link
Collaborator Author

@karl-johan-grahn @d3adb5 Can you please give a look? Thank you!

@karl-johan-grahn
Copy link
Contributor

@aslafy-z Can you please resolve the conflicts?

@rasheedamir
Copy link
Member

@d3adb5 can you plz review it again and approve it?

Copy link
Collaborator

@d3adb5 d3adb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the delay in coming back to this.

@d3adb5
Copy link
Collaborator

d3adb5 commented Aug 11, 2025

Do make sure to do a major version bump afterwards!

@aslafy-z
Copy link
Collaborator Author

aslafy-z commented Aug 19, 2025

@rasheedamir @karl-johan-grahn Can you please also review? This PR needs a second approval.
@d3adb5 Thank you for taking some time to look at this PR!

@aslafy-z aslafy-z requested review from rasheedamir and removed request for karl-johan-grahn August 19, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants