-
Notifications
You must be signed in to change notification settings - Fork 30
Onboard Intake(2/3): introduce Intake #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Onboard Intake(2/3): introduce Intake #1124
Conversation
| func NewCmd(p *params.CmdParams) *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "create", | ||
| Short: "Creates a new Intake", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my understanding: What is an "intake"? Is it kind of an instance (like it is for managed databases)?
Because I would maybe suggest something like stackit beta intake instance create then...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an "Intake" is a data ingestion pipeline configuration. It connects to an Apache Iceberg data catalog (like Dremio) and uses a runner to process data. Its not a database.
You can read more here: https://docs.stackit.cloud/products/data-and-ai/intake/how-tos/create-and-manage-intakes/
@yago-123 discussed with the team we wanted this way, unless you see any issue here:
stackit beta intake create ...
| } | ||
|
|
||
| if !model.AssumeYes { | ||
| prompt := fmt.Sprintf("Are you sure you want to create an Intake for project %q?", projectLabel) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| prompt := fmt.Sprintf("Are you sure you want to create an Intake for project %q?", projectLabel) | |
| prompt := fmt.Sprintf("Are you sure you want to create an Intake instance for project %q?", projectLabel) |
In case it's an instance, I would phrase it like this
|
@devanshcache please note: All of this also applies to #1126 |
Co-authored-by: Ruben Hönle <git@hoenle.xyz>
Description
Intake is composed of three components:
Intake runner has already been merged reference (#952) this PR is continuation of the one of two components of Intake (ticket)
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)