Utilize cache infra #587
Open
Utilize cache infra #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* maxg/cache_1_equiv: Fix testkey
* maxg/cache_2_envcache: Fix testkey
* maxg/cache_2_envcache: Fix testkey
* maxg/cache_2_envcache: Fix testkey
* maxg/cache_1_equivalency: include other TestKeys Fix testkey
* maxg/cache_2_envcache: include other TestKeys Fix testkey
* maxg/cache_2_envcache: include other TestKeys Fix testkey
* maxg/cache_2_envcache: include other TestKeys Fix testkey
* maxg/cache_1_equivalency: Cleanup
* maxg/cache_2_envcache: Merge. Cleanup
* maxg/cache_2_envcache: More tests Tests and fixes
* maxg/cache_2_envcache: Existentials for Xcode 15
* maxg/cache_2_envcache: Enable logging for test. Tweak internal env api. Log guard
* maxg/cache_2_envcache: Release 6.3.0 Assert in debug mode when large content viewer is not placed inside an interaction container Expose largeContentViewerInteraction on LargeContentViewer backing view via protocol Stopped installing xcodes in GitHub Actions file chore: Release 6.2.0 Support accessibility large content viewer Squash
This was referenced Sep 4, 2025
watt
reviewed
Sep 30, 2025
Collaborator
watt
left a comment
watt
left a comment
There was a problem hiding this comment.
Can you rebase this on the maxg/cache_2_envcache branch? Looks like it's got some changes from the other 2 stacked PRs mixed in.
| // Shortcut: If both environments were empty, nothing changed. | ||
| if oldValue.isEmpty && environment.isEmpty { return } | ||
| // Shortcut: If there are no changes to the environment, then, well, nothing changed. | ||
| if let layoutMode, layoutMode.options.skipUnneededSetNeedsViewHierarchyUpdates && oldValue.isEquivalent( |
Collaborator
There was a problem hiding this comment.
self.layoutMode is just one customization point — you should probably use something like:
self.layoutMode ?? RenderContext.current?.layoutMode ?? environment.layoutMode
which I think will match the actual mode used during layout.
watt
reviewed
Oct 8, 2025
Comment on lines
214
to
216
| // Store bounding shapes in this cache to avoid costly recalculations | ||
| private var boundingShapeCache: [Link: Link.BoundingShape] = [:] | ||
|
|
Collaborator
There was a problem hiding this comment.
what happened to the deleted stuff in this file? intentional change, or just a bad merge?
watt
reviewed
Dec 18, 2025
Collaborator
watt
left a comment
watt
left a comment
There was a problem hiding this comment.
Looking good overall, just still a few open questions/comments from the last review on this one.
Contributor
johnnewman-square
left a comment
johnnewman-square
left a comment
There was a problem hiding this comment.
Neat! I'd love to try this out in the Catalog app. Would it be possible to spin up a branch with the new layout settings enabled?
* maxg/cache_2_envcache: Ref semantics for caches Ref semantics for caches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3/3 for caching changes.
Design doc: https://docs.google.com/document/d/1CLhFbzZGbEKgvZTUwLuGbFY-rfZNJVTi6f3PkoZT9qI/edit?usp=sharing
Adds support for caching AttributedLabel string normalization results.
Adds support for skipping calls to setNeedsViewHierarchyUpdate when Environment and Element value changes are equivalent.
Adds support for caching MeasureableStorage measurements.