Skip to content

Added setting to prevent Ldvirtftn argument remove for better DCE opt… #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iskiselev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added setting to prevent Ldvirtftn argument remove for better DCE opt… #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ICSharpCode.Decompiler/DecompilerSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,21 @@ public CSharpFormattingOptions CSharpFormattingOptions {
}
}
}

bool skipLdvirtftnArgumentRemove = false;

public bool SkipLdvirtftnArgumentRemove
{
get { return skipLdvirtftnArgumentRemove; }
set
{
if (skipLdvirtftnArgumentRemove != value)
{
skipLdvirtftnArgumentRemove = value;
OnPropertyChanged("SkipLdvirtftnArgumentRemove");
}
}
}

public event PropertyChangedEventHandler PropertyChanged;

Expand Down
3 changes: 2 additions & 1 deletion ICSharpCode.Decompiler/ILAst/ILAstOptimizer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,8 @@ void IntroducePropertyAccessInstructions(ILExpression expr, ILExpression parentE
if (expr.Arguments[0].Match(ILCode.Ldloc, out target)
&& expr.Arguments[1].Code == ILCode.Ldvirtftn
&& expr.Arguments[1].Arguments.Count == 1
&& expr.Arguments[1].Arguments[0].MatchLdloc(target))
&& expr.Arguments[1].Arguments[0].MatchLdloc(target)
&& !context.Settings.SkipLdvirtftnArgumentRemove)
{
// Remove the 'target' argument from the ldvirtftn instruction.
// It's not needed in the translation to C#, and needs to be eliminated so that the target expression
Expand Down