Skip to content

feat: Support custom punctuation marks in TokenTextSplitter #4942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oneby-wang wants to merge 1 commit into from
Closed

feat: Support custom punctuation marks in TokenTextSplitter #4942

oneby-wang wants to merge 1 commit into from

Conversation

@oneby-wang
Copy link

@oneby-wang oneby-wang commented Nov 23, 2025

  1. Add List<Character> punctuationMarks in TokenTextSplitter.
  2. Add protected method: getLastPunctuationIndex() in TokenTextSplitter.
  3. Add unit test in TokenTextSplitterTest.

feat: Support custom punctuation marks in TokenTextSplitter
632df5f 
Signed-off-by: oneby-wang <onebywang@qq.com>
@oneby-wang oneby-wang force-pushed the token_text_splitter_expose_punctuation_mark branch from 4a50283 to 632df5f Compare November 24, 2025 00:53
@ilayaperumalg ilayaperumalg self-assigned this Dec 2, 2025
@ilayaperumalg ilayaperumalg added the enhancement New feature or request label Dec 2, 2025
@ilayaperumalg ilayaperumalg added this to the 2.0.0.M1 milestone Dec 2, 2025
@ilayaperumalg ilayaperumalg mentioned this pull request Dec 9, 2025
Closed
@ilayaperumalg ilayaperumalg self-assigned this Dec 10, 2025
@ilayaperumalg
Copy link
Member

ilayaperumalg commented Dec 10, 2025

@oneby-wang Thanks for the PR! Rebased and merged as 9773099 and added documentation via e59be78. Backported into 1.1.x as c0e279a and 7abe9a0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ilayaperumalg ilayaperumalg

@markpollack markpollack

Labels

enhancement New feature or request for: backport-to-1.1.x

Projects

None yet

Milestone

2.0.0.M1

Development

Successfully merging this pull request may close these issues.

3 participants

@oneby-wang @ilayaperumalg @markpollack