Skip to content

Conversation

@grantfitzsimmons
Copy link
Member

@grantfitzsimmons grantfitzsimmons commented Jan 5, 2026

Fixes #7607

This PR makes three changes:

  • Fixes the broken 'office' icon (the top windows have returned 🎉)
  • Schema field captions for fields and tables are used instead of hard-coded table names
  • Descriptions for preferences have been updated to reflect the actual behavior

Left is main, Right is issue-7607

Screenshot 2026-01-05 at 15 17 50

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Verify that the aforementioned changes are visible
  • Customize the field caption of collectionobject.CatalogNumber, and change the table names for preparation, collectionobject and collectionobjectgroup
  • Verify that the preferences reflect these changes
  • Test the inheritance preferences and verify it works as expected
  • Test the uniqueness preference and verify it works as expected

@github-project-automation github-project-automation bot moved this to 📋Back Log in General Tester Board Jan 5, 2026
@grantfitzsimmons grantfitzsimmons changed the title fix: fix broken office icon Fix: Miscellaneous Collection Preferences UX issues Jan 5, 2026
@grantfitzsimmons grantfitzsimmons changed the title Fix: Miscellaneous Collection Preferences UX issues fix(preferences): Miscellaneous Collection Preferences UX issues Jan 5, 2026
Triggered by ce087d6 on branch refs/heads/issue-7607
@grantfitzsimmons grantfitzsimmons added this to the 7.12.0 milestone Jan 5, 2026
@grantfitzsimmons grantfitzsimmons marked this pull request as ready for review January 5, 2026 21:23
@grantfitzsimmons grantfitzsimmons requested review from a team and CarolineDenis January 5, 2026 21:23
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify that the aforementioned changes are visible
  • Customize the field caption of collectionobject.CatalogNumber, and change the table names for preparation, collectionobject and collectionobjectgroup
  • Verify that the preferences reflect these changes
  • Test the inheritance preferences and verify it works as expected
  • Test the uniqueness preference and verify it works as expected

Looks good!
Screenshot 2026-01-06 091144

@emenslin emenslin requested a review from a team January 6, 2026 15:24
Copy link
Collaborator

@bhumikaguptaa bhumikaguptaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify that the aforementioned changes are visible
  • Customize the field caption of collectionobject.CatalogNumber, and change the table names for preparation, collectionobject and collectionobjectgroup
  • Verify that the preferences reflect these changes
  • Test the inheritance preferences and verify it works as expected
  • Test the uniqueness preference and verify it works as expected

works as expected!

@grantfitzsimmons grantfitzsimmons merged commit e43f01d into main Jan 6, 2026
9 checks passed
@grantfitzsimmons grantfitzsimmons deleted the issue-7607 branch January 6, 2026 21:58
@github-project-automation github-project-automation bot moved this from 📋Back Log to ✅Done in General Tester Board Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Collection Preferences UX issues

5 participants