Skip to content

Conversation

@CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Aug 14, 2025

Fixes #6213

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

Notes: Taxon will be created for a discipline in the tree viewer not in the config tool

@CarolineDenis CarolineDenis added this to the 7.12.0 milestone Aug 14, 2025
@github-project-automation github-project-automation bot moved this to 📋Back Log in General Tester Board Aug 14, 2025
@CarolineDenis CarolineDenis changed the title Issue 6213 1 Create a configuration tool Aug 14, 2025
@CarolineDenis CarolineDenis changed the base branch from main to issue-2931-1 August 14, 2025 19:12
@CarolineDenis
Copy link
Contributor Author

CarolineDenis commented Aug 19, 2025

  • Add a migration to create a pick list for discipline type field.

Discipline section:
For geography rank configuration, taxon rank configuration, and tree creation:
After adding a new discipline, the page will reload and the discipline will appear in the hierarchy display. Next to the new discipline, two icons will be shown: a globe and a tree. A red warning message will also appear, prompting the user to configure both the taxon tree and the geography tree. The globe icon is conditional—if the geography tree is set to global, it will not be displayed.
When the user clicks on either the tree or globe icon, a dialog will open containing the corresponding rank configuration form. Once both configurations are saved, a “+” icon will appear next to the discipline, allowing the user to add a new collection.

@CarolineDenis CarolineDenis mentioned this pull request Aug 19, 2025
49 tasks
Copy link
Member

@acwhite211 acwhite211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should work, assuming we're ok with the models.CASCADE being added to those models.

return http.HttpResponseBadRequest(e)
except http.Http404 as e:
return http.HttpResponseNotFound(e)
except IntegrityError as e:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to discuss

Copy link
Member

@acwhite211 acwhite211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did more testing. The process of creating all the new records in the configuration tool works well!

We can work more on the UserGroupScopeId issue in the near future. Hopefully we can figure out a solution soon.

Copy link
Contributor

@alesan99 alesan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented jason's suggested changes to the setup PR so the API now works with this PR 👌
You're probably aware of most of these but I wanted to make note of them for reference:

  • I think the spacing looks a bit weird between sections. I think collections need a bit less space, or everything should have the same amount of spacing.
Screenshot 2025-12-30 091134-2
  • An deletion blocker error appears (after a while) when opening a discipline or division. Specify 7 Crash Report - 2025-12-30T16_13_56.557Z.txt

  • Trees need to be created and linked to new disciplines somehow. Right now it works because its falling back to the last created trees.

  • v Icon, not sure which one should be used though.

image

)}
</div>
{newResourceOpen ? (
<Dialog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResourceView is already a dialog so this results in a duplicate dialog underneath.
Removing this dialog looks like it works

Screenshot 2025-12-30 091407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

Add a new configuration page to create new Discipline, Division, Collection

4 participants