-
Notifications
You must be signed in to change notification settings - Fork 41
Add a new treeDefault import feature #6429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
NOTES:
|
|
TODO:
def create_default_trees_view(request):because: logged_in_collection_name = request.user.logincollectionname returns None for me |
Triggered by 441d301 on branch refs/heads/issue-6294
|
@emenslin your issues should be addressed now 👍 The tree titles in the previews are now used as the tree names, and the notifications should now show the correct task ID. Notifications now also have a button to cancel the tree upload as well. Updated the testing instructions |
Triggered by d2f110d on branch refs/heads/issue-6294
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- See that a list of default Taxon trees is displayed
- Click on a default tree and see you get a notification that it is being created.
- Wait and make sure the default tree is successfully created
- Create a new empty tree and make sure it is created successfully.
- Make sure you can start creating a tree and cancel it with the Cancel button in the popup.
- Make sure you can cancel the tree from the "in progress" notification as well.
- The a new secondary Geography tree should be created after a few minutes.
I didn't try every tree so I'm not sure if it's happening everywhere but at least both the ichthyology and entomology trees are missing the kingdom rank, and maybe others, I'm not sure what all ranks should be included.

Tree Def Items are missing Titles and no ranks are checked as enforced or In full name

Ornithology tree failed at the very end of the tree creation process.
After creating the geography tree it did try to create another one right after, however, that could've been an error on my part, I just wanted to mention it in case it might be a bigger problem.
Accept mapping directly instead of just mappingUrl
|
@emenslin All ranks should now be correctly downloaded 👍 Updated testing instructions with the new chrono strat tree too |
Iwantexpresso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
See that a list of default Taxon trees is displayed
-
Click on a default tree and see you get a notification that it is being created.
-
Wait and make sure the default tree is successfully created
-
Create a new empty tree and make sure it is created successfully.
-
Make sure you can start creating a tree and cancel it with the Cancel button in the popup.
-
Make sure you can cancel the tree from the "in progress" notification as well.
- [] The a new secondary Geography tree should be created after a few minutes.
whenever i execute the API command I get the following bad request response when trying to create the secondary geography tree
which is pointing to the full separator within the geography.json files as being the culprit of this. i am not sure if its intended to be there or if the issue lies elsewhere as running specify through a test panel instance.
This is happening on calvermarinemuseum_2025_09_09 and on bohart_entomology_2025_09_09
Whoops, should work now 👍 I gave it a quick test to confirm |
Remove print statements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- See that a list of default Taxon trees is displayed
- Click on a default tree and see you get a notification that it is being created.
- Wait and make sure the default tree is successfully created
- Create a new empty tree and make sure it is created successfully.
- Make sure you can start creating a tree and cancel it with the Cancel button in the popup.
- Make sure you can cancel the tree from the "in progress" notification as well.
- The new secondary Geography tree should be created after a few minutes.
- The new Chronostrat tree should be created after a few minutes.
- I tried uploading all taxon trees, everything uploads successfully except the ornithology tree.
- The root node for geography is just called 'Root' but should be called 'Earth'
- The root node for Chronostrat is called 'Root' but should be called 'Time'
- The chronostratigraphy tree doesn't have an Eon rank. I'm not sure if this is necessary but I wanted to mention it in case it is.
- The
full name separatorfor the root ranks for both chronostrat and geology are set tobut should be set to,.
Hm not sure why its failing, I increased the re-connection delay, so it might work now? |
Fixes #6294, #7488, #7558
Adds
tree/create_default_tree/endpoint to create or populate a tree with records from a CSV retrived from a URL.Also fetches and displays a list of available default taxon trees in the Tree Viewer tree creation dialog.
TODO:
/create_default_tree/accept a CSV url and discipline name. (Right now the frontend fetches a list of CSV files and sends a filename in the request, then the backend extracts the discipline from the filename, and then the backend chooses a url for the discipline from its own list.)Checklist
self-explanatory (or properly documented)
Testing instructions
yourdb.test.specifysystems.org/documentation/api/operations/all/yourdb.test.specifysystems.org/api/create_default_tree/status/YOUR_TASK_ID/. You should see your task id in the response you got.