-
Notifications
You must be signed in to change notification settings - Fork 41
Add save blocker when trying to delete a loaned prep #6374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Triggered by 0b7cc25 on branch refs/heads/issue-1431
grantfitzsimmons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Verify there is a safe blocker telling you that you cannot delete a prep that is on loan
Screen.Recording.2025-03-27.at.9.28.16.PM.mov
specifyweb/frontend/js_src/lib/components/DataModel/businessRuleDefs.ts
Outdated
Show resolved
Hide resolved
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Verify there is a safe blocker telling you that you cannot delete a prep that is on loan
This only works when the preparation is on loan, it does not work if the preparation is linked to any other interaction (e.g. gift, disposal, exchange out)
04-01_08.41.mp4
|
NOTES: |
|
Re: #6374 (comment)
See #5665, I think it's a great idea. Also see this PR I've been thinking about since January: #6110 If you want to extend or take that over that's OK with me. I'll get to it eventually in any case 😄 |
c979ce5 to
ed1d453
Compare
3b83669 to
95e92ce
Compare
pashiav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Verify there is a safe blocker telling you that you cannot delete a prep that is on loan
Works for other interactions other than loan now!
Found that this workflow does not have a save blocker even though it recognizes that there is a linked Loan to the prep.
CO: https://ciscollections20250210-issue-1431.test.specifysystems.org/specify/view/collectionobject/40263/
Loan: https://ciscollections20250210-issue-1431.test.specifysystems.org/specify/view/loan/252/
- View or create a CO with preps
- Interactions -> Loan (or any other interaction) -> add prep from that CO -> Save
- Use the navigator to go back to CO
- Click SHOW_LOANS -> See that there is a loan record
- Delete prep -> Save -> See error
Screen.Recording.2025-04-02.at.11.38.41.AM.1.mov
pashiav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since behavior is expected.
@CarolineDenis: "we do not fix the 'reload' issue it's like that everywhere in Sp"
Areyes42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Verify there is a safe blocker telling you that you cannot delete a prep that is on loan
Looks good, I also tested deleting the prep when browsing in forms on QB and the blocker appeared 👍
Fixes #1431
Checklist
self-explanatory (or properly documented)
Testing instructions
TODO: