-
Notifications
You must be signed in to change notification settings - Fork 41
Add search on synonyms in the QB #5137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not appear to be working unless I am misunderstanding the instructions. I query on any rank -> name and set equal to a taxon that has synonyms but when I check 'search synonyms' only the one node appears.
If I check 'search synonyms' in any tree aside from taxon I get an error.
11-07_15.21.mp4
|
Fixed it so that it will work on all tree tables, not just Taxon. Try it out again @emenslin, thanks.
|
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@specify/ux-testing Can you please check this behavior against Specify 6 and make sure it matches? |
Iwantexpresso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grantfitzsimmons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fundamental issue here is that 'Search Synonyms' is used most often for searching Collection Objects rather than tree names via a tree base table. The inadequate request this PR is based on unfortunately did not clarify this well enough.
See #752 (comment):
Hey guys, this one is quite important. If I create a collection object query and search for a preferred taxon name, it does not return collection objects with the original taxon name that are different (i.e. junior synonyms) to the preferred taxon name. The functionality is as expected in Specify 6.
Also related to this is that when querying collection objects from a taxon name in the taxon tree, the behaviour differs from Specify 6. In 6 you get records where either the taxon name or the preferred taxon name match the searched name, but in 7 it only searches on taxon name, so searches for a senior synonym don't return collection objects identified as the junior synonyms.
See that if I search for a synonym in a database (e.g. Opsanus tau) with Collection Object as the base table, I can still check "Search Synonyms":

This same behavior is expected in 7.
Using a copy of herb_rbge, I see the following:
Left: v7.11.2.1, Right: issue-752

Same query, exported and imported in both: Taxon Synonyms.json
On the v7.11.2.1, only results where synonyms do have an ID that isn't empty are returned (67532). On issue-752, all taxon records are returned (370611).
In neither scenario is "Search Synonyms" checked.
Searching directly for a Full Name for a synonymized node (e.g. Ericaceae) does yield correct results when querying Taxon directly:






Fixes #752
Checklist
and self-explanatory (or properly documented)
Testing instructions