-
Notifications
You must be signed in to change notification settings - Fork 17
Docker: Update library versions caused by dependencies #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release_candidate
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to understand where the JSON and Toolkit dependencies come from.
Do we actually need the latest versions of these libraries?
The latest Toolkit may include breaking changes. I'd recommend sticking with 1.0.6 unless we really need 1.2.0.
For the JSON library update, is there any RAM impact?
|
Hi Paul,
PR 794 updates the versions to what is being used for release builds. I
dont remember which libraries had the dependencies. I found them by
reinstalling all the libraries in the order listed in the Docker file.
There are three libraries that get updated as a result of dependencies from
other libraries. The third one is SEMP from 1.0.4 to 1.0.5 and then to
1.0.6 with your NTRIP change. The output from the GitHub build should
verify the library versions being used for release builds.
Lee Leahy
|
|
Thank you Lee (@LeeLeahy2 ), I still don't see that we need the latest versions of JSON and Toolkit. They may work just fine. But I vote not to update - unless we need to. All the best, |
|
Hi Paul,
I believe that if you look at the GitHub build logs that you will find that
these versions have been sucked in by other library dependencies. When
updating my libraries manually, executing the lines from Docker, these are
the libraries that were installed. Whether you choose to include the PR or
not does not change what the arduino-cli installs due to the dependency
lists. All I was trying to do with the PR is document what is actually
being used after the library updates.
…On Wed, Nov 26, 2025, 1:02 AM Paul Clark ***@***.***> wrote:
*PaulZC* left a comment (sparkfun/SparkFun_RTK_Everywhere_Firmware#794)
<#794 (comment)>
Thank you Lee ***@***.*** <https://github.com/LeeLeahy2> ),
I still don't see that we *need* the latest versions of JSON and Toolkit.
They may work just fine. But I vote not to update - unless we *need* to.
All the best,
Paul
—
Reply to this email directly, view it on GitHub
<#794 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN4TG3JFO34A2SPQNLIQDCD36WCDXAVCNFSM6AAAAACNBP3KHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKOBQG44DKNRSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
ESP32-OTA-Pull has depends=ArduinoJson, forces use of latest version
No description provided.