Dev search #29
Open
Dev search #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Wow! Thank you very much for this awesome PR! 🩷 Although for larger Jar files I thought about maybe using Lucene on a Bytecode index, with that the search would be very fast and you could even use wildcards. But this is an awesome base, thank you! I still need to port a few things to Kotlin before I can properly merge this. But I have picked this project back up, so hopefully we can finally get a new stable release. |
Contributor
Author
|
Thank you for all the hard work! This PR is a bit messy as my main focus was functionality because I really wanted to use this decompiler. Thanks again!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10 and #21 and fixes classes and files being placed in the root folder instead of the proper package.