Skip to content

Fix setup issues #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Bel-Shazzar wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix setup issues #15

Bel-Shazzar wants to merge 4 commits into from

Conversation

@Bel-Shazzar
Copy link

@Bel-Shazzar Bel-Shazzar commented May 19, 2022

Fixes #14 , #10

@Bel-Shazzar Bel-Shazzar changed the title Fix seetup issues Fix setup issues May 19, 2022
@ajite
Copy link

ajite commented Jun 15, 2022

Thanks, it works for me. I hope this can be merged.

@GregorLushaj GregorLushaj mentioned this pull request Aug 11, 2023
Open
mardoodmuh
mardoodmuh suggested changes Dec 4, 2023
View reviewed changes
Copy link

@mardoodmuh mardoodmuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi guys, i really appreciate your efforts and i do like this package, but when i was trying to install it with pip it kept showing this error until i had to install it manually which is really inconvenient and sucks for beginners like me, may you please upload this updates to the pip repository?

@ajite
Copy link

ajite commented Dec 8, 2023

Hi guys, i really appreciate your efforts and i do like this package, but when i was trying to install it with pip it kept showing this error until i had to install it manually which is really inconvenient and sucks for beginners like me, may you please upload this updates to the pip repository?

I published it on pip last year : pip install python-romkan-ng

@dmgerman
Copy link

dmgerman commented May 19, 2025

Another request to please update the package.

thank you in advance

dmgerman pushed a commit to dmgerman/myougiden that referenced this pull request May 19, 2025
@gitmsr
Updated setup script for python 3.13
91f68fd 
Changes in python 3.13 made the setup obsolete

- distutils has been deprecated and replaced by setuptools

- romkan has not being updated and does not compile any more under 3.13
  the author is aware of the problem but has not updated the package.
  For this reason romkan-ng has been uploaded by a contributor

  See soimort/python-romkan#15
@dmgerman dmgerman mentioned this pull request May 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mardoodmuh mardoodmuh mardoodmuh requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Install of romkan 0.2.1 fails

4 participants

@Bel-Shazzar @ajite @dmgerman @mardoodmuh