Fix clippy #605
Merged
Fix clippy #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think this can be undrafted: it looks sensible to me. |
Collaborator
Author
|
So I think this is all from me, for this release window. Did you want me to look through the commits since last release and write up a ChangeLog, or would you prefer to do it? |
Member
|
If you're able to make a first draft, I'd be really grateful! I can then make a pass over it. Might be easiest to do that in an issue / by email rather than a PR dance, but up to you! |
Collaborator
Author
|
Either one of those works for me, will get working on a first draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one isn't worth looking at yet, due to conflicts with #604 (I just want to make the PR so I don't forget!)
So I've currently branched off of that pr, and set this one as a draft.
Once that is in I'll rebase this on master and unset as draft.