Validation of file share mount paths for integration test #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisererik
requested changes
Sep 3, 2019
| df := exec.Command("df") | ||
| grep := exec.Command("grep", "-w", "/mnt") | ||
| cut := exec.Command("awk", "{print $6}")//, "%", "-f", "1") | ||
|
|
Shruthi-1MN
force-pushed
the
fileshare_validation
branch
2 times, most recently
from
df56632 to
bfc2962
Compare
kumarashit
reviewed
Oct 21, 2019
| return s | ||
| } | ||
|
|
||
| func contains(s []string, e string) bool { |
Collaborator
There was a problem hiding this comment.
Why not use contains()
Shruthi-1MN
force-pushed
the
fileshare_validation
branch
from
bfc2962 to
8ecade3
Compare
Shruthi-1MN
force-pushed
the
fileshare_validation
branch
from
8ecade3 to
c22139f
Compare
Codecov Report
@@ Coverage Diff @@
## development #998 +/- ##
============================================
Coverage 34.92% 34.92%
============================================
Files 97 97
Lines 17563 17563
============================================
Hits 6133 6133
Misses 10561 10561
Partials 869 869 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Validation of file share mount paths for integration test
If file share already exists then only this file works fine
This test file is to ensure all the mount path exists on your operating system
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If file share already exists then only this file works fine
This test file is to ensure all the mount path which are created through opensds exists on your operating system
It fails when no file share created from opensds exists on operating system and also when the path doesn't exists on operating system which are created from opensds.
Release note: