-
Notifications
You must be signed in to change notification settings - Fork 15
Release/0.11.0 #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/0.11.0 #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the release version to 0.11.0, updates copyright years to 2025, and adds support for PrivateKey authentication with the Snowflake target.
- Added new fields (PrivateKeyPath, PrivateKeyPassphrase) in the Target struct for Snowflake authentication.
- Updated version numbers, URLs, and copyright notices across multiple files.
- Updated the CHANGELOG to reflect these changes.
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sql_runner/playbook.go | Added PrivateKeyPath and PrivateKeyPassphrase fields. |
| sql_runner/main.go | Updated cliVersion from 0.10.1 to 0.11.0 |
| sql_runner/options.go, etc. | Updated copyrights and minor formatting changes. |
| integration/setup_consul.sh | Updated copyright year. |
| integration/run_tests.sh | Updated copyright year. |
| VERSION, README.md, CHANGELOG | Bump version to 0.11.0 and update release notes. |
| QueryTag string `yaml:"query_tag"` | ||
| Ssl bool | ||
| QueryTag string `yaml:"query_tag"` | ||
| Ssl bool |
Copilot
AI
May 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider adding an inline comment or GoDoc for the 'PrivateKeyPath' field to clarify its expected format and purpose.
| Ssl bool | |
| Ssl bool | |
| // PrivateKeyPath specifies the file path to the private key used for authentication. | |
| // It can be an absolute or relative path, depending on the runtime environment. |
| Ssl bool | ||
| QueryTag string `yaml:"query_tag"` | ||
| Ssl bool | ||
| PrivateKeyPath string `yaml:"private_key_path"` |
Copilot
AI
May 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider adding an inline comment or GoDoc for the 'PrivateKeyPassphrase' field to improve clarity for future maintainers.
| PrivateKeyPath string `yaml:"private_key_path"` | |
| PrivateKeyPath string `yaml:"private_key_path"` | |
| // PrivateKeyPassphrase is the passphrase used to decrypt the private key specified in PrivateKeyPath. | |
| // This field is optional and should be handled securely to avoid exposing sensitive information. |
istreeter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me.
In other Snowplow apps we put the key directly into the config file. Whereas here you put a path in the config file. I guess that's all ok if you have a plan on how to wrap this up in production deployments.
2841b0b to
79ecb23
Compare
No description provided.