Skip to content

Conversation

@jbeemster
Copy link
Member

No description provided.

@jbeemster jbeemster requested a review from Copilot May 13, 2025 13:15
@jbeemster jbeemster self-assigned this May 13, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the release version to 0.11.0, updates copyright years to 2025, and adds support for PrivateKey authentication with the Snowflake target.

  • Added new fields (PrivateKeyPath, PrivateKeyPassphrase) in the Target struct for Snowflake authentication.
  • Updated version numbers, URLs, and copyright notices across multiple files.
  • Updated the CHANGELOG to reflect these changes.

Reviewed Changes

Copilot reviewed 35 out of 35 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sql_runner/playbook.go Added PrivateKeyPath and PrivateKeyPassphrase fields.
sql_runner/main.go Updated cliVersion from 0.10.1 to 0.11.0
sql_runner/options.go, etc. Updated copyrights and minor formatting changes.
integration/setup_consul.sh Updated copyright year.
integration/run_tests.sh Updated copyright year.
VERSION, README.md, CHANGELOG Bump version to 0.11.0 and update release notes.

QueryTag string `yaml:"query_tag"`
Ssl bool
QueryTag string `yaml:"query_tag"`
Ssl bool
Copy link

Copilot AI May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding an inline comment or GoDoc for the 'PrivateKeyPath' field to clarify its expected format and purpose.

Suggested change
Ssl bool
Ssl bool
// PrivateKeyPath specifies the file path to the private key used for authentication.
// It can be an absolute or relative path, depending on the runtime environment.

Copilot uses AI. Check for mistakes.
Ssl bool
QueryTag string `yaml:"query_tag"`
Ssl bool
PrivateKeyPath string `yaml:"private_key_path"`
Copy link

Copilot AI May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding an inline comment or GoDoc for the 'PrivateKeyPassphrase' field to improve clarity for future maintainers.

Suggested change
PrivateKeyPath string `yaml:"private_key_path"`
PrivateKeyPath string `yaml:"private_key_path"`
// PrivateKeyPassphrase is the passphrase used to decrypt the private key specified in PrivateKeyPath.
// This field is optional and should be handled securely to avoid exposing sensitive information.

Copilot uses AI. Check for mistakes.
@coveralls
Copy link

coveralls commented May 13, 2025

Coverage Status

coverage: 27.73% (+1.0%) from 26.721%
when pulling 79ecb23 on release/0.11.0
into 84bef82 on master.

Copy link

@istreeter istreeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

In other Snowplow apps we put the key directly into the config file. Whereas here you put a path in the config file. I guess that's all ok if you have a plan on how to wrap this up in production deployments.

@jbeemster jbeemster force-pushed the release/0.11.0 branch 2 times, most recently from 2841b0b to 79ecb23 Compare May 16, 2025 07:45
@jbeemster jbeemster merged commit 70f1692 into master May 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants