Skip to content

Conversation

@sn
Copy link
Owner

@sn sn commented Aug 11, 2025

This pull request introduces several improvements and updates to the project, focusing on automating CI/CD workflows, updating configuration validation for the latest Pydantic standards, and modernizing documentation and references. The most significant changes are the addition of GitHub Actions workflows for CI, release, and PyPI publishing, as well as updates to configuration validation and project references.

CI/CD Automation

  • Added .github/workflows/ci.yml to automate testing, linting, formatting, type checking, security checks, CLI functionality tests, and code coverage reporting across multiple Python versions. Also includes build and installation verification steps.
  • Added .github/workflows/release.yml to automate release creation on version tag pushes, including changelog generation, building, testing, and uploading release assets.
  • Added .github/workflows/publish.yml to automate package publishing to PyPI on GitHub release events, with full test/build steps and artifact management.

Configuration and Validation Updates

  • Updated all uses of validator to field_validator in ohheycrypto/config/settings.py to comply with Pydantic v2, including correct use of @classmethod and updated validation logic for fields such as position_sizing, ma_long, and API keys. [1] [2] [3] [4]
  • Changed serialization from .dict() to .model_dump() in config saving for compatibility with Pydantic v2.

Reference and Documentation Modernization

  • Updated all URLs in code, documentation, and metadata to point to the new repository location https://github.com/sn/ohheycrypto instead of the previous ohheycrypto/bot. [1] [2] [3] [4]
  • Streamlined installation and quick start instructions in README.md for clarity and ease of use, removing redundancy and updating commands. [1] [2]

Testing and Packaging

  • Fixed test configuration imports and updated mock config fields in tests/conftest.py to match the latest configuration structure.
  • Updated pyproject.toml to modernize package finding configuration for setuptools.

@sn sn self-assigned this Aug 11, 2025
@sn sn merged commit 3616e2e into main Aug 11, 2025
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants