punch 20250917

app-setup/templates/mount-nas-media.sh

@@ -70,7 +70,7 @@ wait_for_network() {
 test_mount() {
   # Test basic mount verification using user-based pattern
   if ! mount | grep "${WHOAMI}" | grep -q "${PLEX_MEDIA_MOUNT}"; then
-    log "⚠️ Mount not visible in system mount table for user ${WHOAMI}"
+    log "⚠️  Mount not visible in system mount table for user ${WHOAMI}"
     return 1
   fi
   log "✅ Mount verification successful (active mount found for ${WHOAMI})"

docs/apps/transmission-setup-README.md

@@ -1,9 +1,17 @@
 # Transmission Setup Documentation
 
-**Script**: `app-setup/transmission-setup.sh`  
-**Purpose**: BitTorrent client installation and comprehensive GUI automation  
-**Created**: 2025-09-08  
-**Status**: Production ready  
+> **⚠️ IMPORTANT SECURITY RECOMMENDATION**
+>
+> **VPN Binding Strongly Recommended**: For privacy and security, it is highly recommended to bind Transmission to a VPN connection to prevent IP address exposure during BitTorrent operations.
+>
+> **Not Included in This Setup**: VPN configuration and binding functionality is NOT included in this automation. You will need to configure VPN binding manually after setup completion.
+>
+> **Manual Configuration Required**: Consult your VPN provider's documentation for instructions on binding applications to VPN interfaces (typically involves network interface binding or kill-switch configuration).
+
+**Script**: `app-setup/transmission-setup.sh`
+**Purpose**: BitTorrent client installation and comprehensive GUI automation
+**Created**: 2025-09-08
+**Status**: Production ready
 
 ## Overview
 

scripts/server/first-boot.sh

@@ -656,40 +656,53 @@ else
     collect_error "FileVault is enabled - incompatible with auto-login setup"
 
     if [[ "${FORCE}" != "true" ]]; then
-      read -p "Would you like to disable FileVault now? (y/N): " -n 1 -r response
-      echo
-      case ${response} in
-        [yY])
-          show_log "Disabling FileVault - this may take 30-60+ minutes..."
-          if sudo -p "[FileVault] Enter password to disable FileVault: " fdesetup disable; then
-            show_log "✅ FileVault disabled successfully"
-            show_log "Auto-login should now work properly"
-          else
-            collect_error "Failed to disable FileVault"
-            show_log ""
-            show_log "ALTERNATIVE OPTIONS (choose ONE):"
-            show_log "1. System Settings > Privacy & Security > FileVault > Turn Off"
-            show_log "2. Run 'sudo fdesetup disable' manually later"
-            show_log "3. Perform clean system installation without FileVault"
-          fi
-          ;;
-        *)
-          show_log "FileVault remains enabled - setup will continue but auto-login may not work"
-          collect_warning "User chose to continue with FileVault enabled"
-          show_log ""
-          show_log "ALTERNATIVE OPTIONS (choose ONE):"
-          show_log "1. Disable via System Settings:"
-          show_log "   • Open System Settings > Privacy & Security > FileVault"
-          show_log "   • Click 'Turn Off...' and follow the prompts"
-          show_log ""
-          show_log "2. Disable via command line:"
-          show_log "   • Run: sudo fdesetup disable"
-          show_log ""
-          show_log "3. If FileVault cannot be disabled:"
-          show_log "   • Wipe this Mac completely and start over"
-          show_log "   • During macOS setup, DO NOT enable FileVault"
-          ;;
-      esac
+      # Loop until FileVault is disabled or user chooses to proceed with it enabled
+      while true; do
+        read -p "Would you like to disable FileVault now? (y/N): " -n 1 -r response
+        echo
+        case ${response} in
+          [yY])
+            show_log "Disabling FileVault - this may take 30-60+ minutes..."
+            if sudo -p "[FileVault] Enter password to disable FileVault: " fdesetup disable -user "${USER}" -verbose; then
+              # Re-check FileVault status to verify it was actually disabled
+              log "Verifying FileVault disable operation..."
+              new_filevault_status=$(fdesetup status 2>/dev/null || echo "unknown")
+              if [[ "${new_filevault_status}" == *"FileVault is Off"* ]]; then
+                show_log "✅ FileVault disabled successfully"
+                show_log "Auto-login should now work properly"
+                break # Success - exit the retry loop
+              else
+                collect_error "FileVault disable command succeeded but FileVault is still enabled"
+                show_log "❌ FileVault disable failed - this usually means the wrong password was entered"
+                show_log ""
+                # Continue the loop to try again
+              fi
+            else
+              collect_error "Failed to disable FileVault"
+              show_log "❌ FileVault disable command failed"
+              show_log ""
+              # Continue the loop to try again
+            fi
+            ;;
+          *)
+            show_log "FileVault remains enabled - setup will continue but auto-login may not work"
+            collect_warning "User chose to continue with FileVault enabled"
+            break # User chose to proceed - exit the retry loop
+            ;;
+        esac
+      done
+      show_log ""
+      show_log "ALTERNATIVE OPTIONS (if auto-login fails):"
+      show_log "1. Disable via System Settings:"
+      show_log "   • Open System Settings > Privacy & Security > FileVault"
+      show_log "   • Click 'Turn Off...' and follow the prompts"
+      show_log ""
+      show_log "2. Disable via command line:"
+      show_log "   • Run: sudo fdesetup disable"
+      show_log ""
+      show_log "3. If FileVault cannot be disabled:"
+      show_log "   • Wipe this Mac completely and start over"
+      show_log "   • During macOS setup, DO NOT enable FileVault"
     else
       collect_warning "Force mode - continuing despite FileVault being enabled"
       show_log "Auto-login functionality will NOT work with FileVault enabled"
@@ -1331,32 +1344,11 @@ fi
 # Setup completed successfully
 section "Setup Complete"
 show_log "Server setup has been completed successfully"
-show_log "You can now set up individual applications with scripts in: ${APP_SETUP_DIR}"
-show_log ""
-show_log "Next steps:"
-show_log "1. Set up applications: cd ${APP_SETUP_DIR} && ./run-app-setup.sh"
-show_log "   (This will install all required applications in sequence)"
-show_log ""
-show_log "2. Test SSH access from your dev machine:"
-show_log "   ssh ${ADMIN_USERNAME}@${HOSTNAME_LOWER}.local"
-show_log "   ssh operator@${HOSTNAME_LOWER}.local"
-show_log ""
-show_log "3. After completing app setup, reboot to enable operator auto-login:"
-show_log "   - Rebooting will automatically log in as '${OPERATOR_USERNAME}'"
-show_log "   - Dock cleanup and operator customization will happen automatically"
-show_log "   - Configure any additional operator-specific settings"
-show_log "   - Test that all applications are accessible as the operator"
-show_log ""
-show_log "4. The next Terminal session, window, or tab will use the installed"
-show_log "   Bash shell and custom settings for both Administrator and Operator accounts."
 
 # Clean up temporary sudo timeout configuration
 log "Removing temporary sudo timeout configuration"
 sudo rm -f /etc/sudoers.d/10_setup_timeout
 
-# External keychain preserved in setup directory for idempotent re-runs
-# (Previously removed keychain after completion, breaking re-run capability)
-
 # Clean up administrator password from memory
 if [[ -n "${ADMINISTRATOR_PASSWORD:-}" ]]; then
   unset ADMINISTRATOR_PASSWORD
@@ -1366,4 +1358,19 @@ fi
 # Show collected errors and warnings
 show_collected_issues
 
+# Show completion dialog and open new Terminal window for app setup
+osascript <<EOF
+tell application "System Events"
+  display dialog "🎉 Server Setup Complete!" & return & return & "The base system configuration is now finished. Click OK to open a new Terminal window where you can run the application setup script." & return & return & "Next: Run ./run-app-setup.sh to install Plex, Transmission, FileBot, and other applications." buttons {"OK"} default button "OK" with title "Setup Complete"
+end tell
+
+tell application "Terminal"
+  activate
+  do script "cd ${APP_SETUP_DIR}"
+end tell
+EOF
+
+log "✅ Setup complete! New Terminal window opened for application setup."
+log "It's now safe to close this Terminal window."
+
 exit 0

scripts/server/setup-terminal-profiles.sh

@@ -200,41 +200,43 @@ import_terminal_profile_for_user() {
     # Import for current admin user - direct registration
     log "Opening Terminal profile to import settings..."
 
-    # Use AppleScript to track window IDs and close only the newly created window
+    # Use AppleScript to safely manage windows without closing the calling script's window
     local applescript_result
     applescript_result=$(osascript -e "
 tell application \"Terminal\"
-    -- Get list of existing window IDs before opening profile
-    set existing_window_ids to {}
-    repeat with w in windows
-        set existing_window_ids to existing_window_ids & {id of w}
-    end repeat
+    -- Save reference to current window (the one running the script)
+    set current_window to front window
+    set current_window_id to id of current_window
 
-    -- Open the profile file (this will create a new window)
+    -- Open the profile file (this will create a new window and bring it to front)
     open POSIX file \"${profile_file}\" as alias
 
-    -- Wait for new window to appear (max 5 seconds)
+    -- Wait for profile import to complete (max 5 seconds)
+    delay 2.5
+
+    -- Bring the calling script's window back to front
+    set index of current_window to 1
+
+    -- Loop until the current window is at the front (max 5 seconds)
     set wait_count to 0
     repeat while wait_count < 10
         delay 0.5
         set wait_count to wait_count + 1
 
-        -- Check if we have a new window
-        repeat with w in windows
-            if (id of w) is not in existing_window_ids then
-                -- Found the new window - close it and exit
-                close w
-                return \"success\"
-            end if
-        end repeat
+        if id of front window = current_window_id then
+            return \"success\"
+        end if
+
+        -- Keep trying to bring current window to front
+        set index of current_window to 1
     end repeat
 
     return \"timeout\"
 end tell
 ")
 
     if [[ "${applescript_result}" == "success" ]]; then
-      log "Successfully imported Terminal profile and closed temporary window"
+      log "Successfully imported Terminal profile and restored calling window focus"
 
       # Set as default and startup profile
       defaults write com.apple.Terminal "Default Window Settings" -string "${profile_name}"