Feature: Gemini ACP Backend #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahundt
added a commit
to ahundt/happy-cli
that referenced
this pull request
Dec 30, 2025
Summary: Integrates PR slopus#99 (hook-based session tracking) and PR slopus#98 (Gemini/ACP integration) while preserving all offline mode and robustness features from the feature branch, plus DRY improvements. What changed: - Session hook server system for reliable Claude session ID capture - Gemini backend as alternative to Claude/Codex with ACP integration - Fixed memory leak in session.ts (stored interval reference + cleanup()) - Added socket connection check in apiSession.ts - Created shared offlineSessionStub.ts utility (DRY refactor) - Added gemini to profile compatibility validation - Preserved: offline mode, 5xx handling, profile system, tmux integration Files affected: - src/claude/runClaude.ts: Hook server + offline fallback integration - src/claude/session.ts: RAII cleanup, callback system, hookSettingsPath - src/claude/loop.ts: hookSettingsPath threading - src/claude/claudeLocal.ts: Hook parameters - src/claude/claudeRemote.ts: mapToClaudeMode() preserved - src/api/api.ts: Graceful 5xx handling preserved - src/api/apiSession.ts: Socket check restored - src/daemon/run.ts: Gemini added to agent selection - src/persistence.ts: Added gemini to ProfileCompatibilitySchema - src/utils/offlineSessionStub.ts: New shared DRY utility - src/codex/runCodex.ts: Updated to use shared offline stub - src/gemini/runGemini.ts: Added offline mode with shared stub - src/agent/*, src/gemini/*: New from main (no conflicts) - scripts/session_hook_forwarder.cjs: Hook forwarder from main Testable: npm test (266 pass, 8 fail - baseline unchanged)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Gemini support to Happy CLI using the Agent Client Protocol (ACP). Users can now run
happy geminito start a Gemini-powered coding assistant with full mobile app integration.Changes
Gemini ACP Backend
New agent architecture:
AgentBackend— abstract interface for AI agent backendsAgentRegistry— factory registry for creating agent instancesAcpSdkBackend— ACP protocol implementation using stdio communicationGemini integration:
gemini --experimental-acpflagGemini CLI Commands
Supported models:
gemini-2.5-pro,gemini-2.5-flash,gemini-2.5-flash-liteAuthentication Priority
Authentication sources (highest to lowest priority):
happy connect gemini)~/.gemini/)GEMINI_API_KEYenvironment variableGOOGLE_API_KEYenvironment variableRequirements
0.21.2+,0.17.1